src/builtins.cc - Issue 8342037: Switch UnreachableObjectsFilter to use Marking instead of InstrusiveMarking.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins.cc

Issue 8342037: Switch UnreachableObjectsFilter to use Marking instead of InstrusiveMarking. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/builtins.cc

diff --git a/src/builtins.cc b/src/builtins.cc

index d513200f0b93c4b49d6a32fecabe6185214ad446..66183ceb00a8f0e49546e56fcda80245aafbbf7d 100644

--- a/src/builtins.cc

+++ b/src/builtins.cc

@@ -371,7 +371,9 @@ static FixedArray* LeftTrimFixedArray(Heap* heap,

int size_delta = to_trim * kPointerSize;

if (heap->marking()->TransferMark(elms->address(),

elms->address() + size_delta)) {

- MemoryChunk::IncrementLiveBytes(elms->address(), -size_delta);

+ if (MarkCompactCollector::IsLiveBytesUpdateRequired(elms)) {

+ MemoryChunk::IncrementLiveBytes(elms->address(), -size_delta);

+ }

}

return FixedArray::cast(HeapObject::FromAddress(

« no previous file with comments | « no previous file | src/heap.h » ('j') | src/heap.cc » ('J')