Switch UnreachableObjectsFilter to use Marking instead of InstrusiveMarking.

Switch UnreachableObjectsFilter to use Marking instead of InstrusiveMarking. 

GcSafeFindCodeForInnerPointer does not work with intrusive marking now and it is used when roots are iterated.

R=erik.corry@gmail.com

Committed: http://code.google.com/p/v8/source/detail?r=9721

[Erik Corry, 2011-10-19 17:56:06]

Should AreMarkBitsTainted be called AreLiveObjectByteCountsUnreliable?  That is
what the bit is used for.

LGTM

http://codereview.chromium.org/8342037/diff/1/src/heap.cc
File src/heap.cc (right):

http://codereview.chromium.org/8342037/diff/1/src/heap.cc#newcode5842
src/heap.cc:5842: switch (filtering_) {
Seems like this switch should just be an if.

http://codereview.chromium.org/8342037/diff/1/src/incremental-marking.cc
File src/incremental-marking.cc (right):

http://codereview.chromium.org/8342037/diff/1/src/incremental-marking.cc#newc...
src/incremental-marking.cc:472:
heap_->mark_compact_collector()->ClearMarkbits();
I don't understand why this is now needed in the incremental case.  It seems to
me that it might cause a longer pause than necessary.

http://codereview.chromium.org/8342037/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):

http://codereview.chromium.org/8342037/diff/1/src/mark-compact.cc#newcode369
src/mark-compact.cc:369: markbits_are_tainted_ = false;
Here you could use SetMarkbitsTainted(false)

http://codereview.chromium.org/8342037/diff/1/src/mark-compact.h
File src/mark-compact.h (right):

http://codereview.chromium.org/8342037/diff/1/src/mark-compact.h#newcode543
src/mark-compact.h:543: void TaintMarkbits() {
I think it would be preferable with a SetTaintMarkbits(bool value)

[Vyacheslav Egorov (Chromium), 2011-10-20 10:45:28]

I have simplified it. 

PTAL

[Erik Corry, 2011-10-20 11:02:47]

LGTM

[mnaganov (inactive), 2011-10-20 17:40:31]

Thank you for fixing this! There was a bug:
http://code.google.com/p/v8/issues/detail?id=1728, I'm closing it.