Issue 8342019: Don't need to export an abstract interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8342019: Don't need to export an abstract interface. (Closed)

Created:
9 years, 2 months ago by wtc

Modified:
9 years, 2 months ago

Reviewers:
palmer, commit-bot: I haz the power, rvargas (doing something else)

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -19 lines)			Patch
M	net/net.gyp	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	net/url_request/fraudulent_certificate_reporter.h	View	1	2 chunks	+2 lines, -4 lines	0 comments	Download
D	net/url_request/fraudulent_certificate_reporter.cc	View		1 chunk	+0 lines, -14 lines	0 comments	Download

Total messages: 6 (0 generated)

wtc

palmer: just FYI. I am making this change to be consistent with the other abstract ...

9 years, 2 months ago (2011-10-19 01:50:54 UTC) #2

palmer

So it actually does build on win_shared? Nice. If it all works, you can get ...

9 years, 2 months ago (2011-10-19 16:56:25 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/8342019/5001

9 years, 2 months ago (2011-10-19 18:35:36 UTC) #5

Change committed as 106355