Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2135)

Unified Diff: content/common/zygote_fork_delegate_linux.h

Issue 8342017: Add UMA reports for Linux nacl_helper startup status (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/zygote_fork_delegate_linux.h
diff --git a/content/common/zygote_fork_delegate_linux.h b/content/common/zygote_fork_delegate_linux.h
index 26dfbc919d1d82111706f336893115db4ec9980e..403cad3b0b88ceba0091b30d1f50873c38912e30 100644
--- a/content/common/zygote_fork_delegate_linux.h
+++ b/content/common/zygote_fork_delegate_linux.h
@@ -19,9 +19,9 @@
class ZygoteForkDelegate {
public:
// A ZygoteForkDelegate is created during Chrome linux zygote
- // initialization, and provides "fork()" functionality with
- // as an alternative to forking the zygote. A new delegate is
- // passed in as an argument to ZygoteMain().
+ // initialization, and provides "fork()" functionality as an
+ // alternative to forking the zygote. A new delegate is passed in
+ // as an argument to ZygoteMain().
ZygoteForkDelegate() {}
virtual ~ZygoteForkDelegate() {}
@@ -31,9 +31,17 @@ class ZygoteForkDelegate {
int browserdesc,
int sandboxdesc) = 0;
- // Returns 'true' if the delegate would like to handle a given
- // fork request. Otherwise returns false.
- virtual bool CanHelp(const std::string& process_type) = 0;
+ // After Init, supply a UMA_HISTOGRAM_ENUMERATION the delegate
+ // would like to have done on the first fork.
agl 2011/10/19 16:17:27 s/have done/supply/ ?
Roland McGrath 2011/10/19 18:34:15 Done.
+ virtual void InitialUMA(std::string* uma_name,
+ int* uma_sample,
+ int* uma_boundary_value) = 0;
+
+ // Returns 'true' if the delegate would like to handle a given fork
+ // request. Otherwise returns false. Optionally, fills in uma_name et al
+ // with a report the helper wants to make via UMA_HISTOGRAM_ENUMERATION.
+ virtual bool CanHelp(const std::string& process_type, std::string* uma_name,
+ int* uma_sample, int* uma_boundary_value) = 0;
// Delegate forks, returning a -1 on failure. Outside the
// suid sandbox, Fork() returns the Linux process ID. Inside
« content/browser/zygote_main_linux.cc ('K') | « content/browser/zygote_main_linux.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698