Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: chrome/common/nacl_fork_delegate_linux.h

Issue 8342017: Add UMA reports for Linux nacl_helper startup status (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased; review nits Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/nacl/nacl_fork_delegate_linux.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_COMMON_NACL_FORK_DELEGATE_LINUX_H_ 5 #ifndef CHROME_COMMON_NACL_FORK_DELEGATE_LINUX_H_
6 #define CHROME_COMMON_NACL_FORK_DELEGATE_LINUX_H_ 6 #define CHROME_COMMON_NACL_FORK_DELEGATE_LINUX_H_
7 #pragma once 7 #pragma once
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
11 #include "content/common/zygote_fork_delegate_linux.h" 11 #include "content/common/zygote_fork_delegate_linux.h"
12 12
13 // The NaClForkDelegate is created during Chrome linux zygote 13 // The NaClForkDelegate is created during Chrome linux zygote
14 // initialization, and provides "fork()" functionality with 14 // initialization, and provides "fork()" functionality with
15 // NaCl specific process characteristics (specifically address 15 // NaCl specific process characteristics (specifically address
16 // space layout) as an alternative to forking the zygote. 16 // space layout) as an alternative to forking the zygote.
17 // A new delegate is passed in as an argument to ZygoteMain(). 17 // A new delegate is passed in as an argument to ZygoteMain().
18 class NaClForkDelegate : public ZygoteForkDelegate { 18 class NaClForkDelegate : public ZygoteForkDelegate {
19 public: 19 public:
20 NaClForkDelegate(); 20 NaClForkDelegate();
21 virtual ~NaClForkDelegate(); 21 virtual ~NaClForkDelegate();
22 22
23 virtual void Init(bool sandboxed, 23 virtual void Init(bool sandboxed,
24 int browserdesc, 24 int browserdesc,
25 int sandboxdesc) OVERRIDE; 25 int sandboxdesc) OVERRIDE;
26 virtual bool CanHelp(const std::string& process_type) OVERRIDE; 26 virtual void InitialUMA(std::string* uma_name,
27 int* uma_sample,
28 int* uma_boundary_value) OVERRIDE;
29 virtual bool CanHelp(const std::string& process_type, std::string* uma_name,
30 int* uma_sample, int* uma_boundary_value) OVERRIDE;
27 virtual pid_t Fork(const std::vector<int>& fds) OVERRIDE; 31 virtual pid_t Fork(const std::vector<int>& fds) OVERRIDE;
28 virtual bool AckChild(int fd, 32 virtual bool AckChild(int fd,
29 const std::string& channel_switch) OVERRIDE; 33 const std::string& channel_switch) OVERRIDE;
30 34
31 private: 35 private:
32 bool ready_; 36 // These values are reported via UMA and hence they become permanent
37 // constants. Old values cannot be reused, only new ones added.
38 enum NaClHelperStatus {
39 kNaClHelperUnused = 0,
40 kNaClHelperMissing = 1,
41 kNaClHelperBootstrapMissing = 2,
42 kNaClHelperValgrind = 3,
43 kNaClHelperLaunchFailed = 4,
44 kNaClHelperAckFailed = 5,
45 kNaClHelperSuccess = 6,
46 kNaClHelperStatusBoundary // Must be one greater than highest value used.
47 };
48
49 NaClHelperStatus status_;
33 bool sandboxed_; 50 bool sandboxed_;
34 int fd_; 51 int fd_;
35 }; 52 };
36 53
37 #endif // CHROME_COMMON_NACL_FORK_DELEGATE_LINUX_H_ 54 #endif // CHROME_COMMON_NACL_FORK_DELEGATE_LINUX_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/nacl/nacl_fork_delegate_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698