Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: webkit/plugins/ppapi/ppb_var_impl.cc

Issue 8342016: Revert 106142 - Add a new globals object for PPAPI tracking information. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/plugins/ppapi/ppb_proxy_impl.cc ('k') | webkit/plugins/ppapi/ppb_video_capture_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/plugins/ppapi/ppb_var_impl.cc
===================================================================
--- webkit/plugins/ppapi/ppb_var_impl.cc (revision 106147)
+++ webkit/plugins/ppapi/ppb_var_impl.cc (working copy)
@@ -11,7 +11,6 @@
#include "ppapi/c/pp_var.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/WebBindings.h"
#include "webkit/plugins/ppapi/common.h"
-#include "webkit/plugins/ppapi/host_globals.h"
#include "webkit/plugins/ppapi/npapi_glue.h"
#include "webkit/plugins/ppapi/npobject_var.h"
#include "webkit/plugins/ppapi/plugin_module.h"
@@ -21,7 +20,6 @@
#include "v8/include/v8.h"
using ppapi::NPObjectVar;
-using ppapi::PpapiGlobals;
using ppapi::StringVar;
using ppapi::Var;
using WebKit::WebBindings;
@@ -126,8 +124,7 @@
NPObjectVar* object() { return object_.get(); }
PluginInstance* GetPluginInstance() {
- return HostGlobals::Get()->host_resource_tracker()->GetInstance(
- object()->pp_instance());
+ return ResourceTracker::Get()->GetInstance(object()->pp_instance());
}
protected:
@@ -173,11 +170,11 @@
// PPB_Var methods -------------------------------------------------------------
void AddRefVar(PP_Var var) {
- PpapiGlobals::Get()->GetVarTracker()->AddRefVar(var);
+ ResourceTracker::Get()->GetVarTracker()->AddRefVar(var);
}
void ReleaseVar(PP_Var var) {
- PpapiGlobals::Get()->GetVarTracker()->ReleaseVar(var);
+ ResourceTracker::Get()->GetVarTracker()->ReleaseVar(var);
}
PP_Var VarFromUtf8(PP_Module module, const char* data, uint32_t len) {
@@ -407,11 +404,10 @@
ppp_class, ppp_class_data);
}
-PP_Var CreateObjectDeprecated(PP_Instance pp_instance,
+PP_Var CreateObjectDeprecated(PP_Instance instance_id,
const PPP_Class_Deprecated* ppp_class,
void* ppp_class_data) {
- PluginInstance* instance =
- HostGlobals::Get()->host_resource_tracker()->GetInstance(pp_instance);
+ PluginInstance* instance = ResourceTracker::Get()->GetInstance(instance_id);
if (!instance) {
DLOG(ERROR) << "Create object passed an invalid instance.";
return PP_MakeNull();
@@ -419,11 +415,10 @@
return PluginObject::Create(instance, ppp_class, ppp_class_data);
}
-PP_Var CreateObjectWithModuleDeprecated(PP_Module pp_module,
+PP_Var CreateObjectWithModuleDeprecated(PP_Module module_id,
const PPP_Class_Deprecated* ppp_class,
void* ppp_class_data) {
- PluginModule* module =
- HostGlobals::Get()->host_resource_tracker()->GetModule(pp_module);
+ PluginModule* module = ResourceTracker::Get()->GetModule(module_id);
if (!module)
return PP_MakeNull();
return PluginObject::Create(module->GetSomeInstance(),
Property changes on: webkit/plugins/ppapi/ppb_var_impl.cc
___________________________________________________________________
Added: svn:mergeinfo
Merged /branches/chrome_webkit_merge_branch/src/webkit/plugins/ppapi/ppb_var_impl.cc:r3734-4217,4606-5108,5177-5263
« no previous file with comments | « webkit/plugins/ppapi/ppb_proxy_impl.cc ('k') | webkit/plugins/ppapi/ppb_video_capture_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698