Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Unified Diff: webkit/plugins/ppapi/ppapi_plugin_instance.cc

Issue 8342016: Revert 106142 - Add a new globals object for PPAPI tracking information. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/plugins/ppapi/plugin_object.cc ('k') | webkit/plugins/ppapi/ppb_audio_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/plugins/ppapi/ppapi_plugin_instance.cc
===================================================================
--- webkit/plugins/ppapi/ppapi_plugin_instance.cc (revision 106147)
+++ webkit/plugins/ppapi/ppapi_plugin_instance.cc (working copy)
@@ -62,7 +62,6 @@
#include "webkit/plugins/ppapi/common.h"
#include "webkit/plugins/ppapi/event_conversion.h"
#include "webkit/plugins/ppapi/fullscreen_container.h"
-#include "webkit/plugins/ppapi/host_globals.h"
#include "webkit/plugins/ppapi/message_channel.h"
#include "webkit/plugins/ppapi/npapi_glue.h"
#include "webkit/plugins/ppapi/plugin_delegate.h"
@@ -103,7 +102,6 @@
using base::StringPrintf;
using ppapi::InputEventImpl;
-using ppapi::PpapiGlobals;
using ppapi::StringVar;
using ppapi::thunk::EnterResourceNoLock;
using ppapi::thunk::PPB_Buffer_API;
@@ -244,8 +242,7 @@
// unchanged.
bool SecurityOriginForInstance(PP_Instance instance_id,
WebKit::WebSecurityOrigin* security_origin) {
- PluginInstance* instance =
- HostGlobals::Get()->host_resource_tracker()->GetInstance(instance_id);
+ PluginInstance* instance = ResourceTracker::Get()->GetInstance(instance_id);
if (!instance)
return false;
@@ -309,7 +306,7 @@
text_input_caret_bounds_(0, 0, 0, 0),
text_input_caret_set_(false),
lock_mouse_callback_(PP_BlockUntilComplete()) {
- pp_instance_ = HostGlobals::Get()->host_resource_tracker()->AddInstance(this);
+ pp_instance_ = ResourceTracker::Get()->AddInstance(this);
memset(&current_print_settings_, 0, sizeof(current_print_settings_));
DCHECK(delegate);
@@ -338,7 +335,7 @@
delegate_->InstanceDeleted(this);
module_->InstanceDeleted(this);
- HostGlobals::Get()->host_resource_tracker()->InstanceDeleted(pp_instance_);
+ ResourceTracker::Get()->InstanceDeleted(pp_instance_);
}
// NOTE: Any of these methods that calls into the plugin needs to take into
@@ -426,7 +423,7 @@
void PluginInstance::InstanceCrashed() {
// Force free all resources and vars.
- HostGlobals::Get()->host_resource_tracker()->InstanceCrashed(pp_instance());
+ ResourceTracker::Get()->InstanceCrashed(pp_instance());
// Free any associated graphics.
SetFullscreen(false, false);
@@ -873,7 +870,7 @@
if (string)
selection = UTF8ToUTF16(string->value());
// Release the ref the plugin transfered to us.
- HostGlobals::Get()->GetVarTracker()->ReleaseVar(rv);
+ ResourceTracker::Get()->GetVarTracker()->ReleaseVar(rv);
return selection;
}
@@ -892,7 +889,7 @@
if (string)
link = UTF8ToUTF16(string->value());
// Release the ref the plugin transfered to us.
- PpapiGlobals::Get()->GetVarTracker()->ReleaseVar(rv);
+ ResourceTracker::Get()->GetVarTracker()->ReleaseVar(rv);
return link;
}
Property changes on: webkit/plugins/ppapi/ppapi_plugin_instance.cc
___________________________________________________________________
Added: svn:mergeinfo
Merged /branches/chrome_webkit_merge_branch/src/webkit/plugins/ppapi/ppapi_plugin_instance.cc:r3734-4217,4606-5108,5177-5263
« no previous file with comments | « webkit/plugins/ppapi/plugin_object.cc ('k') | webkit/plugins/ppapi/ppb_audio_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698