Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 8341139: Options: Fix to enable Edit button only when the current profile is selected. (Closed)

Created:
9 years, 1 month ago by NaveenBobbili (Motorola)
Modified:
9 years, 1 month ago
Reviewers:
mirandac
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Options: Fix to enable Edit button only when the current profile is selected. Prevents a profile from editing the avatar and profile name of another profile in the Personal Options page. These changes got overwritten due to revision 107894. Bringing them back. BUG=87658 TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107901

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/resources/options/personal_options.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
NaveenBobbili (Motorola)
Please review. Submitting changes that are missed when 107894 is committed.
9 years, 1 month ago (2011-10-30 10:29:20 UTC) #1
Miranda Callahan
On 2011/10/30 10:29:20, NaveenBobbili (Motorola) wrote: > Please review. Submitting changes that are missed when ...
9 years, 1 month ago (2011-10-30 11:51:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qghc36@motorola.com/8341139/1
9 years, 1 month ago (2011-10-30 11:52:29 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-10-30 14:37:56 UTC) #4
Change committed as 107901

Powered by Google App Engine
This is Rietveld 408576698