Trigger print immediately on selecting GCP escape hatch on Chrome OS

Trigger print immediately on selecting GCP escape hatch on Chrome OS


BUG=102223
TEST=Bring up print preview in Chrome OS.  Open the printer selection dropdown and choose to search for additional printers.  Print preview should go away and cloud print dialog should appear.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108155

[dpapad, 2011-10-31 15:53:11]

LGTM

http://codereview.chromium.org/8341126/diff/1/chrome/browser/resources/print_...
File chrome/browser/resources/print_preview/print_preview.js (right):

http://codereview.chromium.org/8341126/diff/1/chrome/browser/resources/print_...
chrome/browser/resources/print_preview/print_preview.js:275: if (cr.isChromeOS
&& selectedValue == PRINT_WITH_CLOUD_PRINT) {
Nit: No need for braces.

[Albert Bodenhamer, 2011-10-31 16:51:50]

http://codereview.chromium.org/8341126/diff/1/chrome/browser/resources/print_...
File chrome/browser/resources/print_preview/print_preview.js (right):

http://codereview.chromium.org/8341126/diff/1/chrome/browser/resources/print_...
chrome/browser/resources/print_preview/print_preview.js:275: if (cr.isChromeOS
&& selectedValue == PRINT_WITH_CLOUD_PRINT) {
On 2011/10/31 15:53:12, dpapad wrote:
> Nit: No need for braces.

Done.

[commit-bot: I haz the power, 2011-10-31 18:47:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abodenha@chromium.org/8341126/5001

[commit-bot: I haz the power, 2011-10-31 19:42:03]

Try job failure for 8341126-5001 (retry) on linux_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2011-10-31 19:45:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abodenha@chromium.org/8341126/5001

[commit-bot: I haz the power, 2011-10-31 20:18:52]

Try job failure for 8341126-5001 (retry) on linux_rel for step "update".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2011-10-31 20:49:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abodenha@chromium.org/8341126/5001

[commit-bot: I haz the power, 2011-10-31 21:43:08]

Try job failure for 8341126-5001 (retry) on linux_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2011-11-01 16:19:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abodenha@chromium.org/8341126/5001

[commit-bot: I haz the power, 2011-11-01 16:21:14]

Try job failure for 8341126-5001 on linux_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[dpapad, 2011-11-01 18:08:19]

On 2011/11/01 16:21:14, I haz the power (commit-bot) wrote:
> Try job failure for 8341126-5001 on linux_rel for step "update".
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...
> 
> Step "update" is always a major failure.
> Look at the try server FAQ for more details.

FYI, there is a discussion on another thread stating that it is weird to have a
dropdown selection popping up a new window. Perhaps this CL needs approval from
the UI leads before landing.

[Albert Bodenhamer, 2011-11-01 18:45:33]

I'll go ahead and land this since a lot of people are confused by the current
behavior.  We'll revisit in the context of the current discussion.

On 2011/11/01 18:08:19, dpapad wrote:
> On 2011/11/01 16:21:14, I haz the power (commit-bot) wrote:
> > Try job failure for 8341126-5001 on linux_rel for step "update".
> >
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...
> > 
> > Step "update" is always a major failure.
> > Look at the try server FAQ for more details.
> 
> FYI, there is a discussion on another thread stating that it is weird to have
a
> dropdown selection popping up a new window. Perhaps this CL needs approval
from
> the UI leads before landing.

[commit-bot: I haz the power, 2011-11-01 18:45:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abodenha@chromium.org/8341126/5001

[commit-bot: I haz the power, 2011-11-01 20:11:27]

Change committed as 108155