Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 8341117: Converted top-level NewRunnable* to Bind for Sync module (Closed)

Created:
9 years, 1 month ago by Rick Campbell
Modified:
9 years, 1 month ago
CC:
chromium-reviews, GeorgeY, ncarter (slow), akalin, Raghu Simha, dyu1, Paweł Hajdan Jr., Ilya Sherman, tim (not reviewing), dhollowa
Visibility:
Public.

Description

Converted top-level NewRunnableMethod and straggler NewRunnableFunction usage to Bind for Sync module BUG=102167 TEST=unit_tests/regression Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107822

Patch Set 1 #

Patch Set 2 : Indenting. Removed trailing whitespace. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -110 lines) Patch
M chrome/browser/sync/glue/autofill_data_type_controller.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/sync/glue/browser_thread_model_worker.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/sync/glue/http_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/password_data_type_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/password_model_worker.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.cc View 1 14 chunks +46 lines, -55 lines 0 comments Download
M chrome/browser/sync/notifier/non_blocking_invalidation_notifier.cc View 6 chunks +12 lines, -21 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_harness.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_test_util.cc View 1 4 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/sync/test/integration/autofill_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/passwords_helper.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Rick Campbell
Please take a look.
9 years, 1 month ago (2011-10-28 19:26:51 UTC) #1
akalin
LGTM
9 years, 1 month ago (2011-10-28 20:55:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rickcam@chromium.org/8341117/1001
9 years, 1 month ago (2011-10-28 22:08:53 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-10-28 23:22:04 UTC) #4
Change committed as 107822

Powered by Google App Engine
This is Rietveld 408576698