Issue 8341105: [cros] Use ScheduleSavePersistentPrefs instead of SavePersistentPrefs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8341105: [cros] Use ScheduleSavePersistentPrefs instead of SavePersistentPrefs. (Closed)

Created:
9 years, 1 month ago by Nikita (slow)

Modified:
9 years, 1 month ago

Reviewers:
whywhat, dmazzoni

CC:
chromium-reviews, nkostylev+watch_chromium.org, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, ctguil+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, zork+watch_chromium.org, dmazzoni at google, satorux1

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[cros] Use ScheduleSavePersistentPrefs instead of SavePersistentPrefs. We had to use SavePersistentPref() since prefs were not saved during normal shutdown. See http://crosbug.com/19491 which tracks that, now fixed. Leaving SavePersistentPrefs() in WizardController and DetermineAndSaveHardwareKeyboard since those OOBE settings are very important to be saved right away and persist even if Chrome crashes. BUG=chromium-os:20938 TEST=Manual. OOBE: switch language, reboot. Remove user, reboot. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107737

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -11 lines)			Patch
M	chrome/browser/chromeos/accessibility_util.cc	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	chrome/browser/chromeos/login/language_switch_menu.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/user_manager.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/status/input_method_menu.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

dmazzoni

9 years, 1 month ago (2011-10-28 15:37:54 UTC) #4

LGTM for accessibility_util, since the bug in ScheduleSavePersistentPrefs
appears to be fixed now.

Expand Messages | Collapse Messages

Issue 8341105: [cros] Use ScheduleSavePersistentPrefs instead of SavePersistentPrefs. (Closed)

Description

Patch Set 1 #

Patch Set 2 : remove changes from WizardController #

Patch Set 3 : Remove change from OOBE boot. #

Messages