chrome/browser/ui/panels/panel.cc - Issue 8341098: Mac: Added a delay before panels go to minimized state from title-only state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/panels/panel.cc

Issue 8341098: Mac: Added a delay before panels go to minimized state from title-only state. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: cr feedback Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/panels/base_panel_browser_test.cc ('k') | chrome/browser/ui/panels/panel_browsertest.cc » ('j') | chrome/browser/ui/panels/panel_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/panels/panel.cc

diff --git a/chrome/browser/ui/panels/panel.cc b/chrome/browser/ui/panels/panel.cc

index 418f43fef93d30e1d1d9b597dd773701b4ed8dd4..b81dfba54ed99b2ac643bd33b20064ee4b733d2c 100644

--- a/chrome/browser/ui/panels/panel.cc

+++ b/chrome/browser/ui/panels/panel.cc

@@ -17,6 +17,7 @@

#include "chrome/common/extensions/extension.h"

#include "content/browser/tab_contents/tab_contents.h"

#include "content/common/view_messages.h"

+#include "content/public/browser/notification_service.h"

#include "content/public/browser/notification_source.h"

#include "content/public/browser/notification_types.h"

#include "ui/gfx/rect.h"

@@ -111,6 +112,11 @@ void Panel::SetExpansionState(ExpansionState new_state) {

// The minimized panel should not get the focus.

if (expansion_state_ == MINIMIZED)

Deactivate();

+ content::NotificationService::current()->Notify(

jianli 2011/10/28 21:31:33 Probably we do not need this notification since Ru

Dmitry Titov 2011/10/29 00:04:56 Discussed offline. Decided to go with regualr patt

+ chrome::NOTIFICATION_PANEL_CHANGED_EXPANSION_STATE,

+ content::Source<Panel>(this),

+ content::NotificationService::NoDetails());

}

bool Panel::ShouldBringUpTitlebar(int mouse_x, int mouse_y) const {