Mac: Added a delay before panels go to minimized state from title-only state.

chrome/browser/ui/panels/panel_manager.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_PANELS_PANEL_MANAGER_H_
 #define CHROME_BROWSER_UI_PANELS_PANEL_MANAGER_H_
 #pragma once
 
 #include <vector>
 #include "base/basictypes.h"
@@ skipping 83 matching lines @@
   }
 
   void enable_auto_sizing(bool enabled) {
     auto_sizing_enabled_ = enabled;
   }
 
   void SetWorkAreaForTesting(const gfx::Rect& work_area) {
     SetWorkArea(work_area);
   }
 
+  void remove_delays_for_testing() {
+    remove_delays_for_testing_ = true;
+  }
+
   int minimized_panel_count() {
     return minimized_panel_count_;
   }
 
   // Tests should disable mouse watching if mouse movements will be simulated.
   void disable_mouse_watching() {
     mouse_watching_disabled_ = true;
   }
 #endif
 
@@ skipping 31 matching lines @@
 
   // Rearranges the positions of the panels starting from the given iterator.
   // This is called when the display space has been changed, i.e. working
   // area being changed or a panel being closed.
   void Rearrange(Panels::iterator iter_to_start, int rightmost_position);
 
   // Help functions to drag the given panel.
   void DragLeft();
   void DragRight();
 
-  // Checks if the titlebars have been brought up or down. If not, do not wait
-  // for the notifications to trigger it any more, and start to bring them up or
-  // down immediately.
-  void DelayedBringUpOrDownTitlebarsCheck();
-
   // Does the real job of bringing up or down the titlebars.
   void DoBringUpOrDownTitlebars(bool bring_up);
 
   int GetMaxPanelWidth() const;
   int GetMaxPanelHeight() const;
   int GetRightMostAvailablePosition() const;
 
+  void DelayedBringUpOrDownTitlebarsCheck();

[jennb, 2011/10/29 00:16:51]

If old comment is no longer correct, could you put a new comment here?

[Dmitry Titov, 2011/10/29 00:41:58]

Done.

+
   Panels panels_;
 
   // Stores the panels that are pending to remove. We want to delay the removal
   // when we're in the process of the dragging.
   Panels panels_pending_to_remove_;
 
   // Use a mouse watcher to know when to bring up titlebars to "peek" at
   // minimized panels. Mouse movement is only tracked when there is a minimized
   // panel.
   scoped_ptr<PanelMouseWatcher> panel_mouse_watcher_;
@@ skipping 17 matching lines @@
   // the original position when we cancel the dragging.
   int dragging_panel_original_x_;
 
   // Bounds of the panel to drag. It is first set to the original bounds when
   // the dragging happens. Then it is updated to the position that will be set
   // to when the dragging ends.
   gfx::Rect dragging_panel_bounds_;
 
   scoped_refptr<AutoHidingDesktopBar> auto_hiding_desktop_bar_;
 
+  // Delayed transitions support. Sometimes transitions between minimized and
+  // title-only states are delayed, for better usability with Taskbars/Docks.
   TitlebarAction delayed_titlebar_action_;
-
+  bool remove_delays_for_testing_;
+  CancelableTask* bring_up_down_task_;  // Owned by MessageLoop after posting.

[jianli, 2011/10/29 00:19:18]

For consistency, perhaps we can rename it something like titlebar_action_task_,
or bring_up_or_down_titlebars_task_.

[Dmitry Titov, 2011/10/29 00:41:58]

Done.

   ScopedRunnableMethodFactory<PanelManager> method_factory_;

[jianli, 2011/10/29 00:19:18]

Seems that this is not needed any more.

Also, do we still need to make PanelManager ref counted?

[Dmitry Titov, 2011/10/29 00:41:58]

Removed factory and refcounting.
Added DISABLE_RUNNABLE_METHOD_REFCOUNT(PanelManager) to define empty
AddRef/Release for RunnableMethod impl.

 
   // Whether or not bounds will be updated when the preferred content size is
   // changed. The testing code could set this flag to false so that other tests
   // will not be affected.
   bool auto_sizing_enabled_;
 
   bool mouse_watching_disabled_;  // For tests to simulate mouse movements.
 
   static const int kPanelsHorizontalSpacing = 4;
 
   // Minimum width and height of a panel.
   // Note: The minimum size of a widget (see widget.cc) is fixed to 100x100.
   // TODO(jianli): Need to fix this to support smaller panel.
   static const int kPanelMinWidth = 100;
   static const int kPanelMinHeight = 100;
 
   DISALLOW_COPY_AND_ASSIGN(PanelManager);
 };
 
+DISABLE_RUNNABLE_METHOD_REFCOUNT(PanelManager);

[jennb, 2011/10/29 00:16:51]

Could you add comment explaining why we need this?

[Dmitry Titov, 2011/10/29 00:41:58]

Done.

+
 #endif  // CHROME_BROWSER_UI_PANELS_PANEL_MANAGER_H_