Verify that VERSION_CHANGE transactions are rolled back after crash.

Verify that VERSION_CHANGE transactions are rolled back after crash.

This pyautolib-based test verifies the fix for https://bugs.webkit.org/show_bug.cgi?id=70974 by preparing a database, starting a VERSION_CHANGE transaction, crashing the browser mid-transaction, then validating that nothing was committed.

BUG=98562
TEST=python chrome/test/functional/indexeddb.py

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109092

[jsbell, 2011-11-04 21:47:51]

nirnimesh@: chrome/test/OWNERS review?

[Nirnimesh, 2011-11-04 22:25:09]

http://codereview.chromium.org/8341092/diff/1/chrome/test/functional/indexedd...
File chrome/test/functional/indexeddb.py (right):

http://codereview.chromium.org/8341092/diff/1/chrome/test/functional/indexedd...
chrome/test/functional/indexeddb.py:54: url =
self.GetFileURLForDataPath('indexeddb', 'version_change_crash.html')
maybe use GetHttpUrlForDataPath? (here and above as well)

http://codereview.chromium.org/8341092/diff/1/chrome/test/functional/indexedd...
chrome/test/functional/indexeddb.py:57: self.WaitUntil(lambda:
self._GetTestResult() == 'part1 - complete')
you need to wrap this inside self.assertTrue()

http://codereview.chromium.org/8341092/diff/1/chrome/test/functional/indexedd...
chrome/test/functional/indexeddb.py:65: self.RestartBrowser(clear_profile=False)
RestartBrowser works by quitting the current browser, but there's no current
browser now. So I thought this would error out.
You could call self.setUp() to just fire up the browser.

Don't bother if it works just fine without erroring out.

[jsbell, 2011-11-04 23:15:12]

On 2011/11/04 22:25:09, Nirnimesh wrote:
>
http://codereview.chromium.org/8341092/diff/1/chrome/test/functional/indexedd...
> chrome/test/functional/indexeddb.py:54: url =
> self.GetFileURLForDataPath('indexeddb', 'version_change_crash.html')
> maybe use GetHttpUrlForDataPath? (here and above as well)

Done - makes more sense when passing in a fragment. I'm surprised it worked w/o
that.
 
>
http://codereview.chromium.org/8341092/diff/1/chrome/test/functional/indexedd...
> chrome/test/functional/indexeddb.py:57: self.WaitUntil(lambda:
> self._GetTestResult() == 'part1 - complete')
> you need to wrap this inside self.assertTrue()

Done.
 

http://codereview.chromium.org/8341092/diff/1/chrome/test/functional/indexedd...
> chrome/test/functional/indexeddb.py:65:
self.RestartBrowser(clear_profile=False)
> RestartBrowser works by quitting the current browser, but there's no current
> browser now. So I thought this would error out.
> You could call self.setUp() to just fire up the browser.
> 
> Don't bother if it works just fine without erroring out.

It works as-is. I did try calling self.setUp(), but it requires logic to handle
the clear_profile=False requirement - doable, but this ended up with heavy
StartBrowser() function, so I left it as-is.

[Nirnimesh, 2011-11-05 00:07:52]

LGTM