Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Unified Diff: skia/ext/canvas_paint_win.h

Issue 8341090: Debug checks to make it easier to find reason for CanvasT<>::initialize crash (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix review nits Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « skia/ext/bitmap_platform_device_win.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: skia/ext/canvas_paint_win.h
diff --git a/skia/ext/canvas_paint_win.h b/skia/ext/canvas_paint_win.h
index 961002522b3c6724a4c2b427e5db4b79fbf7011b..f03ef556535e554b026e1cb671549551ad887ef0 100644
--- a/skia/ext/canvas_paint_win.h
+++ b/skia/ext/canvas_paint_win.h
@@ -109,10 +109,7 @@ class CanvasPaintT : public T {
// inset pixels to the screen.
const int width = ps_.rcPaint.right - ps_.rcPaint.left;
const int height = ps_.rcPaint.bottom - ps_.rcPaint.top;
- if (!canvas->initialize(width, height, opaque, NULL)) {
- // Cause a deliberate crash;
- *(char*) 0 = 0;
- }
+ CHECK(canvas->initialize(width, height, opaque, NULL));
// This will bring the canvas into the screen coordinate system for the
// dirty rect
« no previous file with comments | « skia/ext/bitmap_platform_device_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698