Add icon-visibility attribute to cr.ui.Tree.

chrome/browser/resources/shared/js/cr.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 const cr = (function() {
 
   /**
    * Whether we are using a Mac or not.
    * @type {boolean}
    */
@@ skipping 116 matching lines @@
    */
   function dispatchPropertyChange(target, propertyName, newValue, oldValue) {
     var e = new CrEvent(propertyName + 'Change');
     e.propertyName = propertyName;
     e.newValue = newValue;
     e.oldValue = oldValue;
     target.dispatchEvent(e);
   }
 
   /**
+   * Converts a camelCase javascript property name to a hyphenated-lower-case
+   * attribute name.
+   * @param {string} jsName The javascript camelCase property name.
+   * @return {string} The equivalent hyphenated-lower-case attribute name.
+   */
+  function getAttributeName(jsName) {
+    // Convert common case aB to a-b, and ABc to a-bc to cover acronyms such as
+    // getHTMLElement.
+    return jsName.replace(/([a-z](?=[A-Z])|[A-Z](?=[A-Z][a-z]))/g, '$&-')

[arv1, 2011/11/01 17:46:24]

This looks overly complex. The following works just as well.

return jsName.replace(/([A-Z])/g, '-$1').toLowerCase());

(this is the same code we have in Closure)

[flackr, 2011/11/01 17:55:46]

Done. I guess worrying about handling uppercase acronyms is overkill?

+        .toLowerCase();
+  }
+
+  /**
    * The kind of property to define in {@code defineProperty}.
    * @enum {number}
    */
   const PropertyKind = {
     /**
      * Plain old JS property where the backing data is stored as a "private"
      * field on the object.
      */
     JS: 'js',
 
@@ skipping 17 matching lines @@
    * @return {function():*} The getter for the property.
    */
   function getGetter(name, kind) {
     switch (kind) {
       case PropertyKind.JS:
         var privateName = name + '_';
         return function() {
           return this[privateName];
         };
       case PropertyKind.ATTR:
+        var attributeName = getAttributeName(name);
         return function() {
-          return this.getAttribute(name);
+          return this.getAttribute(attributeName);
         };
       case PropertyKind.BOOL_ATTR:
+        var attributeName = getAttributeName(name);
         return function() {
-          return this.hasAttribute(name);
+          return this.hasAttribute(attributeName);
         };
     }
   }
 
   /**
    * Helper function for defineProperty that returns the setter of the right
    * kind.
    * @param {string} name The name of the property we are defining the setter
    *     for.
    * @param {cr.PropertyKind} kind The kind of property we are getting the
@@ skipping 10 matching lines @@
           var oldValue = this[privateName];
           if (value !== oldValue) {
             this[privateName] = value;
             if (opt_setHook)
               opt_setHook.call(this, value, oldValue);
             dispatchPropertyChange(this, name, value, oldValue);
           }
         };
 
       case PropertyKind.ATTR:
+        var attributeName = getAttributeName(name);
         return function(value) {
-          var oldValue = this[name];
+          var oldValue = this[attributeName];
           if (value !== oldValue) {
             if (value == undefined)
-              this.removeAttribute(name);
+              this.removeAttribute(attributeName);
             else
-              this.setAttribute(name, value);
+              this.setAttribute(attributeName, value);
             if (opt_setHook)
               opt_setHook.call(this, value, oldValue);
             dispatchPropertyChange(this, name, value, oldValue);
           }
         };
 
       case PropertyKind.BOOL_ATTR:
+        var attributeName = getAttributeName(name);
         return function(value) {
-          var oldValue = this[name];
+          var oldValue = this[attributeName];
           if (value !== oldValue) {
             if (value)
-              this.setAttribute(name, name);
+              this.setAttribute(attributeName, name);
             else
-              this.removeAttribute(name);
+              this.removeAttribute(attributeName);
             if (opt_setHook)
               opt_setHook.call(this, value, oldValue);
             dispatchPropertyChange(this, name, value, oldValue);
           }
         };
     }
   }
 
   /**
    * Defines a property on an object. When the setter changes the value a
@@ skipping 131 matching lines @@
      * The document that we are currently using.
      * @type {!Document}
      */
     get doc() {
       return doc;
     },
     withDoc: withDoc,
     Event: CrEvent
   };
 })();