Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Issue 8341044: Enhance and refactor ChromeDriver's capability handling. Log warning for (Closed)

Created:
9 years, 2 months ago by kkania
Modified:
9 years, 1 month ago
Reviewers:
Huyen
CC:
chromium-reviews, kkania, Paweł Hajdan Jr.
Visibility:
Public.

Description

Enhance and refactor ChromeDriver's capability handling. Log warning for non-recognized capabilities, return errors on incorrect input types, and allow new format where all options are placed under a chromeOptions dictionary. The latter is needed to simplify handling capabilities on the WebDriver client side. See http://codereview.appspot.com/5307047/. BUG=82895, 94721 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107629

Patch Set 1 : ... #

Total comments: 1

Patch Set 2 : add profile test #

Patch Set 3 : rebase #

Patch Set 4 : ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+632 lines, -177 lines) Patch
M chrome/chrome_tests.gypi View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/test/webdriver/commands/create_session.cc View 1 2 3 chunks +27 lines, -169 lines 0 comments Download
M chrome/test/webdriver/commands/session_with_id.cc View 1 chunk +12 lines, -1 line 0 comments Download
A chrome/test/webdriver/webdriver_capabilities_parser.h View 1 2 3 1 chunk +109 lines, -0 lines 0 comments Download
A chrome/test/webdriver/webdriver_capabilities_parser.cc View 1 2 3 1 chunk +240 lines, -0 lines 0 comments Download
A chrome/test/webdriver/webdriver_capabilities_parser_unittest.cc View 1 2 3 1 chunk +141 lines, -0 lines 0 comments Download
M chrome/test/webdriver/webdriver_util.h View 1 2 3 2 chunks +8 lines, -4 lines 0 comments Download
M chrome/test/webdriver/webdriver_util.cc View 1 2 3 3 chunks +92 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kkania
9 years, 2 months ago (2011-10-26 05:22:15 UTC) #1
Huyen
lgtm http://codereview.chromium.org/8341044/diff/2001/chrome/test/webdriver/webdriver_capabilities_parser_unittest.cc File chrome/test/webdriver/webdriver_capabilities_parser_unittest.cc (right): http://codereview.chromium.org/8341044/diff/2001/chrome/test/webdriver/webdriver_capabilities_parser_unittest.cc#newcode25 chrome/test/webdriver/webdriver_capabilities_parser_unittest.cc:25: TEST(CapabilitiesParser, AllCaps) { Did you forget to add ...
9 years, 1 month ago (2011-10-26 18:05:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkania@chromium.org/8341044/13001
9 years, 1 month ago (2011-10-27 16:56:01 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-10-27 21:39:26 UTC) #4
Change committed as 107629

Powered by Google App Engine
This is Rietveld 408576698