Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: chrome/browser/extensions/syncable_extension_settings_storage.cc

Issue 8341043: Extension settings API: send ACTION_UPDATE rather than ACTION_ADD when a (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_settings_sync_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/syncable_extension_settings_storage.cc
diff --git a/chrome/browser/extensions/syncable_extension_settings_storage.cc b/chrome/browser/extensions/syncable_extension_settings_storage.cc
index 8ec5d178941d6d24a1bd4d8bcc4cdbdc46492e49..95e73f75374322323293e93cbadd9714ca7e77ca 100644
--- a/chrome/browser/extensions/syncable_extension_settings_storage.cc
+++ b/chrome/browser/extensions/syncable_extension_settings_storage.cc
@@ -182,6 +182,9 @@ SyncError SyncableExtensionSettingsStorage::OverwriteLocalSettingsWithSync(
extension_id_,
*it,
sync_value.release()));
+ } else {
+ // Sync and local values are the same, no changes to send.
+ synced_keys_.insert(*it);
}
} else {
// Not synced, delete local setting.
« no previous file with comments | « chrome/browser/extensions/extension_settings_sync_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698