Extension settings API: send ACTION_UPDATE rather than ACTION_ADD when a

Extension settings API: send ACTION_UPDATE rather than ACTION_ADD when a
setting that was already in sync (from MergeDataAndStartSyncing) is changed.


BUG=101635
TEST=ExtensionSettingsSyncTest


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107524

[akalin, 2011-10-26 18:58:34]

LGTM

http://codereview.chromium.org/8341043/diff/1001/chrome/browser/extensions/sy...
File chrome/browser/extensions/syncable_extension_settings_storage.cc (right):

http://codereview.chromium.org/8341043/diff/1001/chrome/browser/extensions/sy...
chrome/browser/extensions/syncable_extension_settings_storage.cc:177: if
(!sync_value->Equals(local_value)) {
backwards test is confusing, can you rewrite as:

if (sync_Value->Equals(...)) {
  synced_keys_...;
} else {
  ...
}

[not at google - send to devlin, 2011-10-27 01:54:39]

http://codereview.chromium.org/8341043/diff/1001/chrome/browser/extensions/sy...
File chrome/browser/extensions/syncable_extension_settings_storage.cc (right):

http://codereview.chromium.org/8341043/diff/1001/chrome/browser/extensions/sy...
chrome/browser/extensions/syncable_extension_settings_storage.cc:177: if
(!sync_value->Equals(local_value)) {
On 2011/10/26 18:58:34, akalin wrote:
> backwards test is confusing, can you rewrite as:
> 
> if (sync_Value->Equals(...)) {
>   synced_keys_...;
> } else {
>   ...
> }

Done.

[commit-bot: I haz the power, 2011-10-27 01:54:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kalman@chromium.org/8341043/4001

[commit-bot: I haz the power, 2011-10-27 03:13:01]

Change committed as 107524