Added logic that will retry to reload+reconnect the mobile payment portal page 5 times before it ...

chrome/browser/resources/mobile_setup.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 
 cr.define('mobile', function() {
 
   function MobileSetup() {
   }
 
   cr.addSingletonGetter(MobileSetup);
 
   MobileSetup.PLAN_ACTIVATION_PAGE_LOADING            = -1;
   MobileSetup.PLAN_ACTIVATION_START                   = 0;
   MobileSetup.PLAN_ACTIVATION_TRYING_OTASP            = 1;
   MobileSetup.PLAN_ACTIVATION_RECONNECTING_OTASP_TRY  = 2;
   MobileSetup.PLAN_ACTIVATION_INITIATING_ACTIVATION   = 3;
   MobileSetup.PLAN_ACTIVATION_RECONNECTING            = 4;
-  MobileSetup.PLAN_ACTIVATION_SHOWING_PAYMENT         = 5;
-  MobileSetup.PLAN_ACTIVATION_DELAY_OTASP             = 6;
-  MobileSetup.PLAN_ACTIVATION_START_OTASP             = 7;
-  MobileSetup.PLAN_ACTIVATION_OTASP                   = 8;
-  MobileSetup.PLAN_ACTIVATION_RECONNECTING_OTASP      = 9;
-  MobileSetup.PLAN_ACTIVATION_DONE                    = 10;
+  MobileSetup.PLAN_ACTIVATION_PAYMENT_PORTAL_LOADING  = 5;
+  MobileSetup.PLAN_ACTIVATION_SHOWING_PAYMENT         = 6;
+  MobileSetup.PLAN_ACTIVATION_RECONNECTING_PAYMENT    = 7;
+  MobileSetup.PLAN_ACTIVATION_DELAY_OTASP             = 8;
+  MobileSetup.PLAN_ACTIVATION_START_OTASP             = 9;
+  MobileSetup.PLAN_ACTIVATION_OTASP                   = 10;
+  MobileSetup.PLAN_ACTIVATION_RECONNECTING_OTASP      = 11;
+  MobileSetup.PLAN_ACTIVATION_DONE                    = 12;
   MobileSetup.PLAN_ACTIVATION_ERROR                   = 0xFF;
 
   MobileSetup.EXTENSION_PAGE_URL =
       'chrome-extension://iadeocfgjdjdmpenejdbfeaocpbikmab';
   MobileSetup.ACTIVATION_PAGE_URL = MobileSetup.EXTENSION_PAGE_URL +
                                     '/activation.html';
   MobileSetup.REDIRECT_POST_PAGE_URL = MobileSetup.EXTENSION_PAGE_URL +
                                        '/redirect.html';
 
   MobileSetup.localStrings_ = new LocalStrings();
 
   MobileSetup.prototype = {
     // Mobile device information.
     deviceInfo_: null,
     frameName_ : '',
     initialized_ : false,
     faked_transaction_ : false,
     payment_shown_ : false,
+    frame_load_error_ : 0,
+    frame_load_ignored_ : true,
     // UI states.
     state_ : -1,
     STATE_UNKNOWN_: "unknown",
     STATE_CONNECTING_: "connecting",
     STATE_ERROR_: "error",
     STATE_PAYMENT_: "payment",
     STATE_ACTIVATING_: "activating",
     STATE_CONNECTED_: "connected",
 
     initialize: function(frame_name, carrierPage) {
@@ skipping 30 matching lines @@
             window.close();
         });
       });
 
       this.changeState_({state: MobileSetup.PLAN_ACTIVATION_PAGE_LOADING});
       setInterval(mobile.MobileSetup.drawProgress, 100);
       // Kick off activation process.
       chrome.send('startActivation', []);
     },
 
-    setupPaymentFrameListener_: function() {
-      $(this.frameName_).addEventListener('load', function(e) {
-        // Flip the visibility of the payment page only after the frame is
-        // fully loaded.
-        if (self.state_ == MobileSetup.PLAN_ACTIVATION_SHOWING_PAYMENT) {
-          $('statusHeader').textContent = '';
-          $('auxHeader').textContent = '';
-          $('finalStatus').classList.add('hidden');
-          $('systemStatus').classList.add('hidden');
-          $('canvas').classList.add('hidden');
-          $('carrierPage').classList.add('hidden');
-          $('paymentForm').classList.remove('hidden');
-        }
-      });
+    onFrameLoaded_: function(success) {
+      chrome.send('paymentPortalLoad', [success ? 'ok' : 'failed']);
     },
 
     loadPaymentFrame_: function(deviceInfo) {
       if (deviceInfo) {
+        this.frame_load_error_ = 0;
         this.deviceInfo_ = deviceInfo;
         if (deviceInfo.post_data && deviceInfo.post_data.length) {
+          this.frame_load_ignored_ = true;
           $(this.frameName_).contentWindow.location.href =

[xiyuan, 2011/10/26 23:17:03]

nit: $(this.frameName_).src = ...

               MobileSetup.REDIRECT_POST_PAGE_URL +
               '?post_data=' + escape(deviceInfo.post_data) +
               '&formUrl=' + escape(deviceInfo.payment_url);
         } else {
-          this.setupPaymentFrameListener_();
+          this.frame_load_ignored_ = false;
           $(this.frameName_).contentWindow.location.href =
               deviceInfo.payment_url;
         }
       }
     },
 
     onMessageReceived_: function(e) {
       if (e.origin !=
               this.deviceInfo_.payment_url.substring(0, e.origin.length) &&
           e.origin != MobileSetup.EXTENSION_PAGE_URL)
         return;
 
       if (e.data.type == 'requestDeviceInfoMsg') {
         this.sendDeviceInfo_();
       } else if (e.data.type == 'framePostReady') {
-        this.setupPaymentFrameListener_();
+        this.frame_load_ignored_ = false;
         this.sendPostFrame_(e.origin);
       } else if (e.data.type == 'reportTransactionStatusMsg') {
         console.log('calling setTransactionStatus from onMessageReceived_');
         $('paymentForm').classList.add('hidden');
         chrome.send('setTransactionStatus', [e.data.status]);
       }
     },
 
     changeState_: function(deviceInfo) {
       var new_state = deviceInfo.state;
       if (this.state_ == new_state)
         return;
       var main = $('mainbody');
       // Map handler state to UX.
       switch(new_state) {
         case MobileSetup.PLAN_ACTIVATION_PAGE_LOADING:
         case MobileSetup.PLAN_ACTIVATION_START:
         case MobileSetup.PLAN_ACTIVATION_DELAY_OTASP:
         case MobileSetup.PLAN_ACTIVATION_START_OTASP:
         case MobileSetup.PLAN_ACTIVATION_RECONNECTING:
+        case MobileSetup.PLAN_ACTIVATION_RECONNECTING_PAYMENT:
         case MobileSetup.PLAN_ACTIVATION_RECONNECTING_OTASP_TRY:
         case MobileSetup.PLAN_ACTIVATION_RECONNECTING_OTASP:
           $('statusHeader').textContent =
               MobileSetup.localStrings_.getString('connecting_header');
           $('auxHeader').textContent =
               MobileSetup.localStrings_.getString('please_wait');
           $('paymentForm').classList.add('hidden');
           $('finalStatus').classList.add('hidden');
           $('systemStatus').classList.remove('hidden');
           $('canvas').classList.remove('hidden');
           $('carrierPage').classList.remove('hidden');
           break;
         case MobileSetup.PLAN_ACTIVATION_TRYING_OTASP:
         case MobileSetup.PLAN_ACTIVATION_INITIATING_ACTIVATION:
         case MobileSetup.PLAN_ACTIVATION_OTASP:
           $('statusHeader').textContent =
               MobileSetup.localStrings_.getString('activating_header');
           $('auxHeader').textContent =
               MobileSetup.localStrings_.getString('please_wait');
           $('paymentForm').classList.add('hidden');
           $('finalStatus').classList.add('hidden');
           $('systemStatus').classList.remove('hidden');
           $('canvas').classList.remove('hidden');
           $('carrierPage').classList.remove('hidden');
           break;
-        case MobileSetup.PLAN_ACTIVATION_SHOWING_PAYMENT:
+        case MobileSetup.PLAN_ACTIVATION_PAYMENT_PORTAL_LOADING:
           $('statusHeader').textContent =
               MobileSetup.localStrings_.getString('connecting_header');
           $('auxHeader').textContent = '';
           $('paymentForm').classList.add('hidden');
           $('finalStatus').classList.add('hidden');
           $('systemStatus').classList.remove('hidden');
           $('canvas').classList.remove('hidden');
           this.loadPaymentFrame_(deviceInfo);
+          break;
+        case MobileSetup.PLAN_ACTIVATION_SHOWING_PAYMENT:
+          $('statusHeader').textContent = '';
+          $('auxHeader').textContent = '';
+          $('finalStatus').classList.add('hidden');
+          $('systemStatus').classList.add('hidden');
+          $('canvas').classList.add('hidden');
+          $('carrierPage').classList.add('hidden');
+          $('paymentForm').classList.remove('hidden');
           this.payment_shown_ = true;
           break;
         case MobileSetup.PLAN_ACTIVATION_DONE:
           $('statusHeader').textContent = '';
           $('auxHeader').textContent = '';
           $('finalHeader').textContent =
               MobileSetup.localStrings_.getString('completed_header');
           $('finalMessage').textContent =
               MobileSetup.localStrings_.getString('completed_text');
           $('systemStatus').classList.add('hidden');
@@ skipping 30 matching lines @@
           $('finalStatus').classList.remove('hidden');
           break;
       }
       this.state_ = new_state;
     },
 
     updateDeviceStatus_: function(deviceInfo) {
       this.changeState_(deviceInfo);
     },
 
+    portalFrameLoadError_: function(errorCode) {
+      if (this.frame_load_ignored_)
+        return;
+      console.log("Portal frame load error detected: " + errorCode);
+      this.frame_load_error_ = errorCode;
+    },
+
+    portalFrameLoadCompleted_: function() {
+      if (this.frame_load_ignored_)
+        return;
+      console.log("Portal frame load completed!");
+      this.onFrameLoaded_(this.frame_load_error_ == 0);
+    },
+
     sendPostFrame_ : function(frameUrl) {
       var msg = { type: 'postFrame' };
       $(this.frameName_).contentWindow.postMessage(msg, frameUrl);
     },
 
     sendDeviceInfo_ : function() {
       var msg = {
         type: 'deviceInfoMsg',
         domain: document.location,
         payload: {
@@ skipping 44 matching lines @@
       ctx.closePath();
       ctx.fillStyle = "rgba(240, 30, 29, " + opacity + ")";
       ctx.fill();
     }
   };
 
   MobileSetup.deviceStateChanged = function(deviceInfo) {
     MobileSetup.getInstance().updateDeviceStatus_(deviceInfo);
   };
 
+  MobileSetup.portalFrameLoadError = function(errorCode) {
+    MobileSetup.getInstance().portalFrameLoadError_(errorCode);
+  };
+
+  MobileSetup.portalFrameLoadCompleted = function() {
+    MobileSetup.getInstance().portalFrameLoadCompleted_();
+  };
+
   MobileSetup.loadPage = function() {
     mobile.MobileSetup.getInstance().initialize('paymentForm',
         mobile.MobileSetup.ACTIVATION_PAGE_URL);
   };
 
   // Export
   return {
     MobileSetup: MobileSetup
   };
 
 });