Added logic that will retry to reload+reconnect the mobile payment portal page 5 times before it ...

Added logic that will retry to reload+reconnect the mobile payment portal page 5 times before it eventually gives up and shows service unavailable error.

Expanded frame sniffer to send an event when a frame which is being watched gets finally loaded. From the sent error (or its absence) and this new event, we can finally reconstruct on the browser side if a given iframe was loaded successfully or not.  

BUG=chromium-os:20525, chromium-os:21738
TEST=tricky one to test since it repros on 3g network flakyness. one can edit /usr/lib/cromo/config/madison.ini and put a bad value for olp_root there to trigger this.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107613

[Jason Glasgow, 2011-10-26 21:25:36]

LGTM
one nit on comment, the mobile_setup_ui.{h,cc} code looks fine, but you need
another reviewer for the js and frame sniffer.

[zel, 2011-10-26 22:44:35]

+xiyuan@ for JS part

+jam@ for chrome/renderer/frame_sniffer.*

[xiyuan, 2011-10-26 23:17:03]

LGTM on mobile_setup*

http://codereview.chromium.org/8341037/diff/7001/chrome/browser/resources/mob...
File chrome/browser/resources/mobile_setup.js (right):

http://codereview.chromium.org/8341037/diff/7001/chrome/browser/resources/mob...
chrome/browser/resources/mobile_setup.js:107:
$(this.frameName_).contentWindow.location.href =
nit: $(this.frameName_).src = ...

http://codereview.chromium.org/8341037/diff/7001/chrome/browser/ui/webui/chro...
File chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc (right):

http://codereview.chromium.org/8341037/diff/7001/chrome/browser/ui/webui/chro...
chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc:162:
DISALLOW_COPY_AND_ASSIGN(PortalFrameLoadObserver);
nit: This should be the last.

[jam, 2011-10-27 00:44:29]

On 2011/10/26 22:44:35, zel wrote:
> +xiyuan@ for JS part
> 
> +jam@ for chrome/renderer/frame_sniffer.*

lgtm (but note i'm not familiar with this file)

[commit-bot: I haz the power, 2011-10-27 18:07:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zelidrag@chromium.org/8341037/10012

[commit-bot: I haz the power, 2011-10-27 18:07:38]

Presubmit check for 8341037-10012 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  chrome/browser/ui/webui/chromeos/mobile_setup_dialog.cc, line 116, 84 chars

Presubmit checks took 2.2s to calculate.