Chromium Code Reviews| Index: client/html/src/DocumentFragmentWrappingImplementation.dart |
| diff --git a/client/html/src/DocumentFragmentWrappingImplementation.dart b/client/html/src/DocumentFragmentWrappingImplementation.dart |
| index b1a512f52e7503e155ae7c3eca82a7dffcab298b..03099853160e641f176b6243e86c02d3fdba75b3 100644 |
| --- a/client/html/src/DocumentFragmentWrappingImplementation.dart |
| +++ b/client/html/src/DocumentFragmentWrappingImplementation.dart |
| @@ -107,15 +107,9 @@ class FilteredElementList implements ElementList { |
| } |
| class EmptyStyleDeclaration extends CSSStyleDeclarationWrappingImplementation { |
| - String get cssText() => ""; |
| - int get length() => 0; |
| - CSSRule get parentRule() => null; |
| - CSSValue getPropertyCSSValue(String propertyName) => null; |
| - String getPropertyPriority(String propertyName) => ""; |
| - String getPropertyShorthand(String propertyName) => null; |
| - String getPropertyValue(String propertyName) => null; |
| - bool isPropertyImplicit(String propertyName) => false; |
| - String item(int index) => ""; |
| + // This can't call super(), since that's a factory constructor |
| + EmptyStyleDeclaration() |
| + : super._wrap(dom.document.createElement('div').style) {} |
|
Jacob
2011/10/25 23:45:51
wouldn't
super._wrap(null);
be sufficient?
also
nweiz
2011/10/26 00:27:37
DOMWrapperBase assumes _ptr is non-null.
Jacob
2011/10/26 01:03:13
I'd suggest adding an alternate
_empty()
construc
Anton Muhin
2011/10/26 13:24:05
Why it's needed? I would really prefer not to hav
nweiz
2011/10/26 17:30:53
I think it's useful to have this constructor wrap
Jacob
2011/10/27 01:03:44
I disagree with this reasoning because if the dumm
|
| void set cssText(String value) { |
| throw new UnsupportedOperationException( |