Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2161)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/i18n/time_formatting.cc

Issue 8341026: Replace most LOG/CHECK statements with DLOG/DCHECK statements in base. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/i18n/icu_util.cc ('k') | base/linux_util.cc » ('j') | base/process_util_mac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/i18n/time_formatting.cc
===================================================================
--- base/i18n/time_formatting.cc (revision 107052)
+++ base/i18n/time_formatting.cc (working copy)
@@ -75,15 +75,15 @@
UErrorCode status = U_ZERO_ERROR;
scoped_ptr<icu::DateTimePatternGenerator> generator(
icu::DateTimePatternGenerator::createInstance(status));
- CHECK(U_SUCCESS(status));
+ DCHECK(U_SUCCESS(status));
const char* base_pattern = (type == k12HourClock ? "ahm" : "Hm");
icu::UnicodeString generated_pattern =
generator->getBestPattern(icu::UnicodeString(base_pattern), status);
- CHECK(U_SUCCESS(status));
+ DCHECK(U_SUCCESS(status));
// Then, format the time using the generated pattern.
icu::SimpleDateFormat formatter(generated_pattern, status);
- CHECK(U_SUCCESS(status));
+ DCHECK(U_SUCCESS(status));
if (ampm == kKeepAmPm) {
return TimeFormat(&formatter, time);
} else {
« no previous file with comments | « base/i18n/icu_util.cc ('k') | base/linux_util.cc » ('j') | base/process_util_mac.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698