Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 8341026: Replace most LOG/CHECK statements with DLOG/DCHECK statements in base. (Closed)

Created:
9 years, 2 months ago by brettw
Modified:
9 years, 1 month ago
CC:
chromium-reviews, Paweł Hajdan Jr., sadrul, jshin+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Replace most LOG/CHECK statements with DLOG/DCHECK statements in base. [ Reland of 107042 http://codereview.chromium.org/8368009 ] I tried hard not to change CHECKs that had side effects. I kept fatal checks that seemed security or debugging-info (in crash reports) sensitive, and ones that seems particularly well-conceived. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107434

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -247 lines) Patch
M base/allocator/allocator_shim.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/allocator/allocator_unittests.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M base/android/jni_array.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/base_paths_linux.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M base/command_line.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M base/debug/debugger.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/debug/trace_event.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/dir_reader_posix_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/event_recorder_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/file_util.h View 1 chunk +1 line, -1 line 0 comments Download
M base/file_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/file_util_posix.cc View 12 chunks +31 lines, -31 lines 0 comments Download
M base/file_util_win.cc View 7 chunks +14 lines, -14 lines 0 comments Download
M base/files/file_path_watcher_mac.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M base/files/file_path_watcher_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M base/global_descriptors_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/icu_util.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M base/i18n/time_formatting.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M base/linux_util.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M base/mac/foundation_util.mm View 5 chunks +5 lines, -5 lines 0 comments Download
M base/mac/mac_util.mm View 18 chunks +21 lines, -21 lines 0 comments Download
M base/mac/objc_property_releaser.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M base/message_loop.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M base/message_pump_glib.cc View 1 chunk +4 lines, -1 line 0 comments Download
M base/message_pump_libevent.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/message_pump_x.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M base/metrics/histogram.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M base/metrics/stats_table.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/mime_util_xdg.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/native_library_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/process_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/process_util_linux.cc View 8 chunks +10 lines, -9 lines 0 comments Download
M base/process_util_mac.mm View 14 chunks +15 lines, -14 lines 1 comment Download
M base/process_util_openbsd.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M base/process_util_posix.cc View 10 chunks +16 lines, -16 lines 0 comments Download
M base/process_util_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/rand_util_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/scoped_temp_dir.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/sha1_win.cc View 3 chunks +9 lines, -7 lines 0 comments Download
M base/shared_memory_posix.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/shared_memory_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/sync_socket_posix.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M base/synchronization/condition_variable_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/system_monitor/system_monitor.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M base/system_monitor/system_monitor_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/test/test_file_util_mac.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M base/test/test_file_util_posix.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M base/threading/non_thread_safe_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/platform_thread_mac.mm View 4 chunks +4 lines, -4 lines 0 comments Download
M base/threading/platform_thread_posix.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/threading/simple_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/thread_checker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/thread_local_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/thread_local_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/vlog.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M base/win/i18n.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
This should be the same as the previous patch but with one conversion reverted. There ...
9 years, 2 months ago (2011-10-25 18:08:07 UTC) #1
jar (doing other things)
9 years, 2 months ago (2011-10-25 21:58:40 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698