Issue 8341019: Fix bug in inlining call-as-function when inlining multiple levels deep.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8341019: Fix bug in inlining call-as-function when inlining multiple levels deep. (Closed)

Created:
9 years, 2 months ago by fschneider

Modified:
9 years, 1 month ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix bug in inlining call-as-function when inlining multiple levels deep. This change fixes a off-by-one level error when dropping the function from the environment. The function of the outermost environment was not dropped. BUG=v8:1785 TEST=test/mjsunit/compiler/regress-inline-callfunctionstub.js Committed: http://code.google.com/p/v8/source/detail?r=9789

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 2 months ago

	Unified diffs	Side-by-side diffs	Stats (+57 lines, -5 lines)
M	src/hydrogen.h	View	1 chunk	+1 line, -1 line	0 comments
M	src/hydrogen.cc	View	4 chunks	+10 lines, -4 lines	0 comments
A	test/mjsunit/compiler/regress-inline-callfunctionstub.js	View	1 chunk	+46 lines, -0 lines	0 comments

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Yuck.  LGTM.

Expand Messages | Collapse Messages