Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 8341009: Make the GC aware of JSReceiver pointers in LookupResults. (Closed)

Created:
9 years, 2 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 2 months ago
CC:
v8-dev
Visibility:
Public.

Description

Make the GC aware of JSReceiver pointers in LookupResults. The LookupResult utility class is used in handlified code, but it can contain a raw pointer to the lookup's holder object. Create a per-thread stack of live LookupResults and iterate all the live ones on GC. R=vegorov@chromium.org,erik.corry@gmail.com BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9676

Patch Set 1 #

Patch Set 2 : Inlined LookupResult constructor and destructor. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -95 lines) Patch
M src/api.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/stub-cache-arm.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/ast.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/hydrogen.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/stub-cache-ia32.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/ic.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/isolate.h View 2 chunks +10 lines, -0 lines 0 comments Download
M src/isolate.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/mips/stub-cache-mips.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/objects.cc View 1 28 chunks +40 lines, -40 lines 0 comments Download
M src/profile-generator.cc View 1 1 chunk +5 lines, -4 lines 0 comments Download
M src/property.h View 1 3 chunks +19 lines, -3 lines 0 comments Download
M src/property.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M src/runtime.cc View 1 12 chunks +12 lines, -12 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/stub-cache-x64.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
Context for this change: we already have a potentially unsafe of this class, and we'd ...
9 years, 2 months ago (2011-10-18 09:07:32 UTC) #1
Vyacheslav Egorov (Chromium)
9 years, 2 months ago (2011-10-18 10:59:38 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698