Issue 8341002: VP8: fix up handling of segmentation_maps in reference frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8341002: VP8: fix up handling of segmentation_maps in reference frames. (Closed)

Created:
9 years, 2 months ago by scherkus (not reviewing)

Modified:
9 years, 2 months ago

Reviewers:
Chris Evans, rbultje1

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/deps/third_party

Visibility:
Public.

Description

VP8: fix up handling of segmentation_maps in reference frames. Associate segmentation_map[] with reference frame, rather than decoding instance. This fixes cases where the map would be free()'ed on e.g. a size change in one thread, whereas the other thread was still accessing it. Also, it fixes cases where threads overwrite data that is still being referenced by the previous thread, who thinks that it's part of the frame previously decoded by the next thread. Patch by rbultje@chromium.org. BUG=100464 TEST=run file in bug report TBR=rbultje Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105977

Patch Set 1 #

Patch Set 2 : merge #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+249 lines, -14 lines)			Patch
M	ffmpeg/patches/README	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
A	ffmpeg/patches/to_upstream/42_vp8_fix_segmentation_maps.patch	View		1 chunk	+180 lines, -0 lines	0 comments	Download
M	ffmpeg/source/patched-ffmpeg/libavcodec/vp8.h	View		2 chunks	+10 lines, -1 line	0 comments	Download
M	ffmpeg/source/patched-ffmpeg/libavcodec/vp8.c	View		9 chunks	+55 lines, -13 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages