Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Side by Side Diff: src/ia32/full-codegen-ia32.cc

Issue 8340029: Temporarily disable target recording CallFunctionStub until issue 1789 is fixed. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2167 matching lines...) Expand 10 before | Expand all | Expand 10 after
2178 int arg_count = args->length(); 2178 int arg_count = args->length();
2179 { PreservePositionScope scope(masm()->positions_recorder()); 2179 { PreservePositionScope scope(masm()->positions_recorder());
2180 for (int i = 0; i < arg_count; i++) { 2180 for (int i = 0; i < arg_count; i++) {
2181 VisitForStackValue(args->at(i)); 2181 VisitForStackValue(args->at(i));
2182 } 2182 }
2183 } 2183 }
2184 // Record source position for debugger. 2184 // Record source position for debugger.
2185 SetSourcePosition(expr->position()); 2185 SetSourcePosition(expr->position());
2186 2186
2187 // Record call targets in unoptimized code, but not in the snapshot. 2187 // Record call targets in unoptimized code, but not in the snapshot.
2188 bool record_call_target = !Serializer::enabled(); 2188 // TODO(1789): Reenable temporarily disabled recording CallFunctionStub
2189 // when the issue is fixed.
2190 bool record_call_target = false && !Serializer::enabled();
2189 if (record_call_target) { 2191 if (record_call_target) {
2190 flags = static_cast<CallFunctionFlags>(flags | RECORD_CALL_TARGET); 2192 flags = static_cast<CallFunctionFlags>(flags | RECORD_CALL_TARGET);
2191 } 2193 }
2192 CallFunctionStub stub(arg_count, flags); 2194 CallFunctionStub stub(arg_count, flags);
2193 __ CallStub(&stub, expr->id()); 2195 __ CallStub(&stub, expr->id());
2194 if (record_call_target) { 2196 if (record_call_target) {
2195 // There is a one element cache in the instruction stream. 2197 // There is a one element cache in the instruction stream.
2196 #ifdef DEBUG 2198 #ifdef DEBUG
2197 int return_site_offset = masm()->pc_offset(); 2199 int return_site_offset = masm()->pc_offset();
2198 #endif 2200 #endif
(...skipping 2223 matching lines...) Expand 10 before | Expand all | Expand 10 after
4422 *context_length = 0; 4424 *context_length = 0;
4423 return previous_; 4425 return previous_;
4424 } 4426 }
4425 4427
4426 4428
4427 #undef __ 4429 #undef __
4428 4430
4429 } } // namespace v8::internal 4431 } } // namespace v8::internal
4430 4432
4431 #endif // V8_TARGET_ARCH_IA32 4433 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698