Salient parts of http://codereview.chromium.org/8392042/

Salient parts of http://codereview.chromium.org/8392042/

This is all of the changes under content/ (some of those are just
search-replace), and a few of the changes under chrome/.

BUG=none
TEST=none

[Jói, 2011-10-27 15:40:29]

John, here is the content/ side of the change plus some salient bits under
chrome/, hopefully this makes it easier to review.

I'll forward a patch file for the rest (everything except what's in this
Rietveld patch).

Cheers,
Jói

[Jói, 2011-10-27 15:43:31]

Attached are the parts that weren't under content/ and didn't look
interesting to me (these are just changing #includes and renaming
BrowserThread to either DeprecatedBrowserThread or
content::TestBrowserThread).

I'll follow up with another way of looking at it, that should help you
verify you've looked at everything that isn't basically just a
search-and-replace.

Cheers,
Jói


On Thu, Oct 27, 2011 at 3:40 PM,  <joi@chromium.org> wrote:
> Reviewers: John Abd-El-Malek,
>
> Message:
> John, here is the content/ side of the change plus some salient bits under
> chrome/, hopefully this makes it easier to review.
>
> I'll forward a patch file for the rest (everything except what's in this
> Rietveld patch).
>
> Cheers,
> Jói
>
>
> Description:
> Salient parts of http://codereview.chromium.org/8392042/
>
> This is all of the changes under content/ (some of those are just
> search-replace), and a few of the changes under chrome/.
>
> BUG=none
> TEST=none
>
>
> Please review this at http://codereview.chromium.org/8340028/
>
> SVN Base: http://git.chromium.org/chromium/src.git@master
>
> Affected files:
>  M chrome/chrome_tests.gypi
>  M chrome/tools/DEPS
>  M content/browser/appcache/chrome_appcache_service.h
>  M content/browser/appcache/chrome_appcache_service_unittest.cc
>  M content/browser/browser_child_process_host.cc
>  M content/browser/browser_main.cc
>  M content/browser/browser_main_loop.h
>  M content/browser/browser_main_loop.cc
>  M content/browser/browser_message_filter.h
>  M content/browser/browser_process_sub_thread.h
>  M content/browser/browser_process_sub_thread.cc
>  D content/browser/browser_thread.h
>  D content/browser/browser_thread.cc
>  A content/browser/browser_thread_impl.h
>  A + content/browser/browser_thread_impl.cc
>  M content/browser/browser_thread_unittest.cc
>  M content/browser/child_process_launcher.cc
>  M content/browser/chrome_blob_storage_context.h
>  M content/browser/debugger/devtools_http_protocol_handler.cc
>  M content/browser/debugger/devtools_manager.cc
>  M content/browser/debugger/devtools_netlog_observer.cc
>  M content/browser/debugger/worker_devtools_manager.cc
>  M content/browser/device_orientation/message_filter.cc
>  M content/browser/device_orientation/provider.cc
>  M content/browser/download/base_file.cc
>  M content/browser/download/base_file_unittest.cc
>  M content/browser/download/download_file.cc
>  M content/browser/download/download_file_manager.cc
>  M content/browser/download/download_file_unittest.cc
>  M content/browser/download/download_id_unittest.cc
>  M content/browser/download/download_item.cc
>  M content/browser/download/download_manager.h
>  M content/browser/download/download_manager.cc
>  M content/browser/download/download_request_handle.cc
>  M content/browser/download/download_resource_handler.cc
>  M content/browser/download/drag_download_file.cc
>  M content/browser/download/drag_download_util.cc
>  M content/browser/download/mhtml_generation_manager.h
>  M content/browser/download/save_file.cc
>  M content/browser/download/save_file_manager.cc
>  M content/browser/download/save_file_resource_handler.cc
>  M content/browser/download/save_package.cc
>  M content/browser/download/save_package_unittest.cc
>  M content/browser/file_system/browser_file_system_helper.cc
>  M content/browser/font_list_async.cc
>  M content/browser/geolocation/core_location_data_provider_mac.h
>  M content/browser/geolocation/gps_location_provider_unittest_linux.cc
>  M content/browser/gpu/gpu_data_manager.cc
>  M content/browser/gpu/gpu_process_host.cc
>  M content/browser/gpu/gpu_process_host_ui_shim.cc
>  M content/browser/host_zoom_map.h
>  M content/browser/host_zoom_map.cc
>  M content/browser/in_process_webkit/dom_storage_context.cc
>  M content/browser/in_process_webkit/dom_storage_message_filter.cc
>  M content/browser/in_process_webkit/dom_storage_unittest.cc
>  M content/browser/in_process_webkit/indexed_db_context.h
>  M content/browser/in_process_webkit/indexed_db_context.cc
>  M content/browser/in_process_webkit/indexed_db_dispatcher_host.cc
>  M content/browser/in_process_webkit/indexed_db_quota_client_unittest.cc
>  M content/browser/in_process_webkit/webkit_context.cc
>  M content/browser/in_process_webkit/webkit_context_unittest.cc
>  M content/browser/in_process_webkit/webkit_thread.h
>  M content/browser/in_process_webkit/webkit_thread.cc
>  M content/browser/mach_broker_mac.cc
>  M content/browser/net/url_request_slow_download_job.cc
>  M content/browser/plugin_loader_posix.cc
>  M content/browser/plugin_loader_posix_unittest.cc
>  M content/browser/plugin_process_host.cc
>  M content/browser/plugin_process_host_mac.cc
>  M content/browser/plugin_service.cc
>  M content/browser/plugin_service_browsertest.cc
>  M content/browser/power_save_blocker_common.cc
>  M content/browser/power_save_blocker_mac.cc
>  M content/browser/power_save_blocker_win.cc
>  M content/browser/renderer_host/accelerated_plugin_view_mac.mm
>  M content/browser/renderer_host/buffered_resource_handler.cc
>  M content/browser/renderer_host/clipboard_message_filter_mac.mm
>  M content/browser/renderer_host/java_bridge_dispatcher_host.cc
>  M content/browser/renderer_host/media/audio_input_device_manager.cc
>  M
> content/browser/renderer_host/media/audio_input_device_manager_unittest.cc
>  M content/browser/renderer_host/media/audio_input_renderer_host.h
>  M content/browser/renderer_host/media/audio_renderer_host.h
>  M content/browser/renderer_host/media/audio_renderer_host_unittest.cc
>  M content/browser/renderer_host/media/media_stream_device_settings.cc
>  M
> content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc
>  M content/browser/renderer_host/media/media_stream_manager.cc
>  M content/browser/renderer_host/media/video_capture_controller.cc
>  M content/browser/renderer_host/media/video_capture_host_unittest.cc
>  content/browser/renderer_host/media/video_capture_manager.cc
>  M content/browser/renderer_host/media/video_capture_manager_unittest.cc
>  M content/browser/renderer_host/pepper_file_message_filter.cc
>  M content/browser/renderer_host/pepper_message_filter.cc
>  M content/browser/renderer_host/render_message_filter.cc
>  M content/browser/renderer_host/render_process_host.cc
>  M content/browser/renderer_host/render_view_host_notification_task.h
>  M content/browser/renderer_host/render_widget_helper.cc
>  M content/browser/renderer_host/render_widget_host_unittest.cc
>  M content/browser/renderer_host/render_widget_host_view_mac.mm
>  M content/browser/renderer_host/render_widget_host_view_mac_unittest.mm
>  M content/browser/renderer_host/render_widget_host_view_win.cc
>  M content/browser/renderer_host/resource_dispatcher_host_unittest.cc
>  M content/browser/renderer_host/resource_handler.h
>  M content/browser/renderer_host/resource_message_filter.cc
>  M content/browser/renderer_host/resource_queue.cc
>  M content/browser/renderer_host/resource_queue_unittest.cc
>  M content/browser/renderer_host/text_input_client_message_filter.mm
>  M content/browser/resolve_proxy_msg_helper_unittest.cc
>  M content/browser/resource_context.cc
>  M content/browser/site_instance_unittest.cc
>  M content/browser/speech/speech_input_manager.cc
>  M content/browser/speech/speech_recognizer.cc
>  M content/browser/speech/speech_recognizer_unittest.cc
>  M content/browser/ssl/ssl_client_auth_handler.h
>  M content/browser/ssl/ssl_client_auth_handler.cc
>  M content/browser/ssl/ssl_error_handler.cc
>  M content/browser/ssl/ssl_manager.cc
>  M content/browser/tab_contents/interstitial_page.cc
>  M content/browser/tab_contents/render_view_host_manager_unittest.cc
>  M content/browser/tab_contents/web_drag_source_mac.mm
>  M content/browser/user_metrics.cc
>  M content/browser/utility_process_host.h
>  M content/browser/worker_host/worker_process_host.cc
>  M content/content_browser.gypi
>  M content/content_tests.gypi
>  A + content/public/browser/browser_thread.h
>  M content/shell/shell_browser_context.cc
>  M content/shell/shell_download_manager_delegate.cc
>  M content/shell/shell_url_request_context_getter.cc
>  A content/test/test_browser_thread.h
>  A content/test/test_browser_thread.cc
>  M content/test/test_url_fetcher_factory.h
>
>
>

[Jói, 2011-10-27 15:51:35]

Here's another way to look at the change more quickly:

I wrote the attached script (review_helper.py), thinking it might be
nice to customize for more of our move-style changes.  You can verify
the rules it uses to ignore files pretty easily:  If all + lines
contain one of the patterns mentioned in CategorizePerFileDiffs (and
there are some extra patterns just for files containing "test.") then
that file is considered a "search and replace" file and goes to the
.searchandreplace patch.  Otherwise the diff for that whole file goes
to the .manual part of the patch.  This way you only need to look at a
96K patch file, and can just skim the other 501K file.

Attached is the script, the original patch (most current version) and
the .manual and .searchandreplace parts.

Cheers,
Jói


2011/10/27 Jói Sigurðsson <joi@chromium.org>:
> Attached are the parts that weren't under content/ and didn't look
> interesting to me (these are just changing #includes and renaming
> BrowserThread to either DeprecatedBrowserThread or
> content::TestBrowserThread).
>
> I'll follow up with another way of looking at it, that should help you
> verify you've looked at everything that isn't basically just a
> search-and-replace.
>
> Cheers,
> Jói
>
>
> On Thu, Oct 27, 2011 at 3:40 PM,  <joi@chromium.org> wrote:
>> Reviewers: John Abd-El-Malek,
>>
>> Message:
>> John, here is the content/ side of the change plus some salient bits under
>> chrome/, hopefully this makes it easier to review.
>>
>> I'll forward a patch file for the rest (everything except what's in this
>> Rietveld patch).
>>
>> Cheers,
>> Jói
>>
>>
>> Description:
>> Salient parts of http://codereview.chromium.org/8392042/
>>
>> This is all of the changes under content/ (some of those are just
>> search-replace), and a few of the changes under chrome/.
>>
>> BUG=none
>> TEST=none
>>
>>
>> Please review this at http://codereview.chromium.org/8340028/
>>
>> SVN Base: http://git.chromium.org/chromium/src.git@master
>>
>> Affected files:
>>  M chrome/chrome_tests.gypi
>>  M chrome/tools/DEPS
>>  M content/browser/appcache/chrome_appcache_service.h
>>  M content/browser/appcache/chrome_appcache_service_unittest.cc
>>  M content/browser/browser_child_process_host.cc
>>  M content/browser/browser_main.cc
>>  M content/browser/browser_main_loop.h
>>  M content/browser/browser_main_loop.cc
>>  M content/browser/browser_message_filter.h
>>  M content/browser/browser_process_sub_thread.h
>>  M content/browser/browser_process_sub_thread.cc
>>  D content/browser/browser_thread.h
>>  D content/browser/browser_thread.cc
>>  A content/browser/browser_thread_impl.h
>>  A + content/browser/browser_thread_impl.cc
>>  M content/browser/browser_thread_unittest.cc
>>  M content/browser/child_process_launcher.cc
>>  M content/browser/chrome_blob_storage_context.h
>>  M content/browser/debugger/devtools_http_protocol_handler.cc
>>  M content/browser/debugger/devtools_manager.cc
>>  M content/browser/debugger/devtools_netlog_observer.cc
>>  M content/browser/debugger/worker_devtools_manager.cc
>>  M content/browser/device_orientation/message_filter.cc
>>  M content/browser/device_orientation/provider.cc
>>  M content/browser/download/base_file.cc
>>  M content/browser/download/base_file_unittest.cc
>>  M content/browser/download/download_file.cc
>>  M content/browser/download/download_file_manager.cc
>>  M content/browser/download/download_file_unittest.cc
>>  M content/browser/download/download_id_unittest.cc
>>  M content/browser/download/download_item.cc
>>  M content/browser/download/download_manager.h
>>  M content/browser/download/download_manager.cc
>>  M content/browser/download/download_request_handle.cc
>>  M content/browser/download/download_resource_handler.cc
>>  M content/browser/download/drag_download_file.cc
>>  M content/browser/download/drag_download_util.cc
>>  M content/browser/download/mhtml_generation_manager.h
>>  M content/browser/download/save_file.cc
>>  M content/browser/download/save_file_manager.cc
>>  M content/browser/download/save_file_resource_handler.cc
>>  M content/browser/download/save_package.cc
>>  M content/browser/download/save_package_unittest.cc
>>  M content/browser/file_system/browser_file_system_helper.cc
>>  M content/browser/font_list_async.cc
>>  M content/browser/geolocation/core_location_data_provider_mac.h
>>  M content/browser/geolocation/gps_location_provider_unittest_linux.cc
>>  M content/browser/gpu/gpu_data_manager.cc
>>  M content/browser/gpu/gpu_process_host.cc
>>  M content/browser/gpu/gpu_process_host_ui_shim.cc
>>  M content/browser/host_zoom_map.h
>>  M content/browser/host_zoom_map.cc
>>  M content/browser/in_process_webkit/dom_storage_context.cc
>>  M content/browser/in_process_webkit/dom_storage_message_filter.cc
>>  M content/browser/in_process_webkit/dom_storage_unittest.cc
>>  M content/browser/in_process_webkit/indexed_db_context.h
>>  M content/browser/in_process_webkit/indexed_db_context.cc
>>  M content/browser/in_process_webkit/indexed_db_dispatcher_host.cc
>>  M content/browser/in_process_webkit/indexed_db_quota_client_unittest.cc
>>  M content/browser/in_process_webkit/webkit_context.cc
>>  M content/browser/in_process_webkit/webkit_context_unittest.cc
>>  M content/browser/in_process_webkit/webkit_thread.h
>>  M content/browser/in_process_webkit/webkit_thread.cc
>>  M content/browser/mach_broker_mac.cc
>>  M content/browser/net/url_request_slow_download_job.cc
>>  M content/browser/plugin_loader_posix.cc
>>  M content/browser/plugin_loader_posix_unittest.cc
>>  M content/browser/plugin_process_host.cc
>>  M content/browser/plugin_process_host_mac.cc
>>  M content/browser/plugin_service.cc
>>  M content/browser/plugin_service_browsertest.cc
>>  M content/browser/power_save_blocker_common.cc
>>  M content/browser/power_save_blocker_mac.cc
>>  M content/browser/power_save_blocker_win.cc
>>  M content/browser/renderer_host/accelerated_plugin_view_mac.mm
>>  M content/browser/renderer_host/buffered_resource_handler.cc
>>  M content/browser/renderer_host/clipboard_message_filter_mac.mm
>>  M content/browser/renderer_host/java_bridge_dispatcher_host.cc
>>  M content/browser/renderer_host/media/audio_input_device_manager.cc
>>  M
>> content/browser/renderer_host/media/audio_input_device_manager_unittest.cc
>>  M content/browser/renderer_host/media/audio_input_renderer_host.h
>>  M content/browser/renderer_host/media/audio_renderer_host.h
>>  M content/browser/renderer_host/media/audio_renderer_host_unittest.cc
>>  M content/browser/renderer_host/media/media_stream_device_settings.cc
>>  M
>> content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc
>>  M content/browser/renderer_host/media/media_stream_manager.cc
>>  M content/browser/renderer_host/media/video_capture_controller.cc
>>  M content/browser/renderer_host/media/video_capture_host_unittest.cc
>>  content/browser/renderer_host/media/video_capture_manager.cc
>>  M content/browser/renderer_host/media/video_capture_manager_unittest.cc
>>  M content/browser/renderer_host/pepper_file_message_filter.cc
>>  M content/browser/renderer_host/pepper_message_filter.cc
>>  M content/browser/renderer_host/render_message_filter.cc
>>  M content/browser/renderer_host/render_process_host.cc
>>  M content/browser/renderer_host/render_view_host_notification_task.h
>>  M content/browser/renderer_host/render_widget_helper.cc
>>  M content/browser/renderer_host/render_widget_host_unittest.cc
>>  M content/browser/renderer_host/render_widget_host_view_mac.mm
>>  M content/browser/renderer_host/render_widget_host_view_mac_unittest.mm
>>  M content/browser/renderer_host/render_widget_host_view_win.cc
>>  M content/browser/renderer_host/resource_dispatcher_host_unittest.cc
>>  M content/browser/renderer_host/resource_handler.h
>>  M content/browser/renderer_host/resource_message_filter.cc
>>  M content/browser/renderer_host/resource_queue.cc
>>  M content/browser/renderer_host/resource_queue_unittest.cc
>>  M content/browser/renderer_host/text_input_client_message_filter.mm
>>  M content/browser/resolve_proxy_msg_helper_unittest.cc
>>  M content/browser/resource_context.cc
>>  M content/browser/site_instance_unittest.cc
>>  M content/browser/speech/speech_input_manager.cc
>>  M content/browser/speech/speech_recognizer.cc
>>  M content/browser/speech/speech_recognizer_unittest.cc
>>  M content/browser/ssl/ssl_client_auth_handler.h
>>  M content/browser/ssl/ssl_client_auth_handler.cc
>>  M content/browser/ssl/ssl_error_handler.cc
>>  M content/browser/ssl/ssl_manager.cc
>>  M content/browser/tab_contents/interstitial_page.cc
>>  M content/browser/tab_contents/render_view_host_manager_unittest.cc
>>  M content/browser/tab_contents/web_drag_source_mac.mm
>>  M content/browser/user_metrics.cc
>>  M content/browser/utility_process_host.h
>>  M content/browser/worker_host/worker_process_host.cc
>>  M content/content_browser.gypi
>>  M content/content_tests.gypi
>>  A + content/public/browser/browser_thread.h
>>  M content/shell/shell_browser_context.cc
>>  M content/shell/shell_download_manager_delegate.cc
>>  M content/shell/shell_url_request_context_getter.cc
>>  A content/test/test_browser_thread.h
>>  A content/test/test_browser_thread.cc
>>  M content/test/test_url_fetcher_factory.h
>>
>>
>>
>