net/http/http_stream_factory_impl_request.cc - Issue 8340026: Use AuthCredentials throughout the network stack instead of username/password.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_stream_factory_impl_request.cc

Issue 8340026: Use AuthCredentials throughout the network stack instead of username/password. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Reduce password zapping Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_stream_factory_impl_request.cc

diff --git a/net/http/http_stream_factory_impl_request.cc b/net/http/http_stream_factory_impl_request.cc

index 17c717e00b29967f69854253930b345ad1ef5ebd..493aa431d99d987a7d99b0fb9178d8436785546e 100644

--- a/net/http/http_stream_factory_impl_request.cc

+++ b/net/http/http_stream_factory_impl_request.cc

@@ -196,10 +196,9 @@ void HttpStreamFactoryImpl::Request::OnHttpsProxyTunnelResponse(

}

int HttpStreamFactoryImpl::Request::RestartTunnelWithProxyAuth(

- const string16& username,

- const string16& password) {

+ const AuthCredentials& credentials) {

DCHECK(bound_job_.get());

- return bound_job_->RestartTunnelWithProxyAuth(username, password);

+ return bound_job_->RestartTunnelWithProxyAuth(credentials);

}

LoadState HttpStreamFactoryImpl::Request::GetLoadState() const {

« net/http/http_cache_transaction.h ('K') | « net/http/http_stream_factory_impl_request.h ('k') | net/http/http_transaction.h » ('j') | net/socket_stream/socket_stream.h » ('J')