net/url_request/url_request_test_util.cc - Issue 8340026: Use AuthCredentials throughout the network stack instead of username/password.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_test_util.cc

Issue 8340026: Use AuthCredentials throughout the network stack instead of username/password. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fix comments Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/url_request/url_request_test_util.cc

diff --git a/net/url_request/url_request_test_util.cc b/net/url_request/url_request_test_util.cc

index 768e5209b25705a5cf38783bae4b6389df344dd6..3a7533200a2aa7cf94782f0091fd45e88b85ab6a 100644

--- a/net/url_request/url_request_test_util.cc

+++ b/net/url_request/url_request_test_util.cc

@@ -195,8 +195,8 @@ void TestDelegate::OnReceivedRedirect(net::URLRequest* request,

void TestDelegate::OnAuthRequired(net::URLRequest* request,

net::AuthChallengeInfo* auth_info) {

auth_required_ = true;

- if (!username_.empty() || !password_.empty()) {

- request->SetAuth(username_, password_);

+ if (!credentials_.Empty()) {

+ request->SetAuth(credentials_);

} else {

request->CancelAuth();

}

« no previous file with comments | « net/url_request/url_request_test_util.h ('k') | net/url_request/url_request_unittest.cc » ('j') | no next file with comments »