net/socket_stream/socket_stream.h - Issue 8340026: Use AuthCredentials throughout the network stack instead of username/password.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket_stream/socket_stream.h

Issue 8340026: Use AuthCredentials throughout the network stack instead of username/password. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fix comments Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/socket_stream/socket_stream.h

diff --git a/net/socket_stream/socket_stream.h b/net/socket_stream/socket_stream.h

index 2a4f0d7c14a7897b7d4e41c84f36cd024cfa66dd..9539ca67a4ef284d78c89e2b2447171a4bd5a513 100644

--- a/net/socket_stream/socket_stream.h

+++ b/net/socket_stream/socket_stream.h

@@ -13,7 +13,6 @@

#include "base/memory/linked_ptr.h"

#include "base/memory/ref_counted.h"

#include "base/memory/scoped_ptr.h"

-#include "base/string16.h"

#include "base/task.h"

#include "net/base/address_list.h"

#include "net/base/completion_callback.h"

@@ -151,9 +150,7 @@ class NET_EXPORT SocketStream

// Restarts with authentication info.

// Should be used for response of OnAuthRequired.

- virtual void RestartWithAuth(

- const string16& username,

- const string16& password);

+ virtual void RestartWithAuth(const AuthCredentials& credentials);

// Detach delegate. Call before delegate is deleted.

// Once delegate is detached, close the socket stream and never call delegate

« no previous file with comments | « net/socket/ssl_client_socket_pool_unittest.cc ('k') | net/socket_stream/socket_stream.cc » ('j') | no next file with comments »