Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Unified Diff: net/http/http_cache_transaction.h

Issue 8340026: Use AuthCredentials throughout the network stack instead of username/password. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fix comments Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_auth_sspi_win_unittest.cc ('k') | net/http/http_cache_transaction.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_cache_transaction.h
diff --git a/net/http/http_cache_transaction.h b/net/http/http_cache_transaction.h
index 665f92f3b54ef340c6d6c505ef95bb3f8bff01c1..cc96e80227f18e10d5c2343e11d67da450f59348 100644
--- a/net/http/http_cache_transaction.h
+++ b/net/http/http_cache_transaction.h
@@ -11,7 +11,6 @@
#include <string>
-#include "base/string16.h"
#include "base/time.h"
#include "net/base/net_log.h"
#include "net/http/http_cache.h"
@@ -103,8 +102,7 @@ class HttpCache::Transaction : public HttpTransaction {
virtual int RestartIgnoringLastError(OldCompletionCallback* callback);
virtual int RestartWithCertificate(X509Certificate* client_cert,
OldCompletionCallback* callback);
- virtual int RestartWithAuth(const string16& username,
- const string16& password,
+ virtual int RestartWithAuth(const AuthCredentials& credentials,
OldCompletionCallback* callback);
virtual bool IsReadyToRestartForAuth();
virtual int Read(IOBuffer* buf, int buf_len, OldCompletionCallback* callback);
@@ -258,8 +256,7 @@ class HttpCache::Transaction : public HttpTransaction {
// Called to restart a network transaction with authentication credentials.
// Returns network error code.
- int RestartNetworkRequestWithAuth(const string16& username,
- const string16& password);
+ int RestartNetworkRequestWithAuth(const AuthCredentials& credentials);
// Called to determine if we need to validate the cache entry before using it.
bool RequiresValidation();
« no previous file with comments | « net/http/http_auth_sspi_win_unittest.cc ('k') | net/http/http_cache_transaction.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698