Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Unified Diff: net/http/http_auth_handler_negotiate_unittest.cc

Issue 8340026: Use AuthCredentials throughout the network stack instead of username/password. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fix comments Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_auth_handler_negotiate.cc ('k') | net/http/http_auth_handler_ntlm.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_auth_handler_negotiate_unittest.cc
diff --git a/net/http/http_auth_handler_negotiate_unittest.cc b/net/http/http_auth_handler_negotiate_unittest.cc
index e43d99446191fe73e2faf2427d2d021856f87c38..4c013d21d514eaa2317e493eef01aef28ab87bb3 100644
--- a/net/http/http_auth_handler_negotiate_unittest.cc
+++ b/net/http/http_auth_handler_negotiate_unittest.cc
@@ -223,8 +223,7 @@ TEST_F(HttpAuthHandlerNegotiateTest, DisableCname) {
TestOldCompletionCallback callback;
HttpRequestInfo request_info;
std::string token;
- EXPECT_EQ(OK, auth_handler->GenerateAuthToken(NULL, NULL,
- &request_info,
+ EXPECT_EQ(OK, auth_handler->GenerateAuthToken(NULL, &request_info,
&callback, &token));
#if defined(OS_WIN)
EXPECT_EQ(L"HTTP/alias", auth_handler->spn());
@@ -242,8 +241,7 @@ TEST_F(HttpAuthHandlerNegotiateTest, DisableCnameStandardPort) {
TestOldCompletionCallback callback;
HttpRequestInfo request_info;
std::string token;
- EXPECT_EQ(OK, auth_handler->GenerateAuthToken(NULL, NULL,
- &request_info,
+ EXPECT_EQ(OK, auth_handler->GenerateAuthToken(NULL, &request_info,
&callback, &token));
#if defined(OS_WIN)
EXPECT_EQ(L"HTTP/alias", auth_handler->spn());
@@ -261,8 +259,7 @@ TEST_F(HttpAuthHandlerNegotiateTest, DisableCnameNonstandardPort) {
TestOldCompletionCallback callback;
HttpRequestInfo request_info;
std::string token;
- EXPECT_EQ(OK, auth_handler->GenerateAuthToken(NULL, NULL,
- &request_info,
+ EXPECT_EQ(OK, auth_handler->GenerateAuthToken(NULL, &request_info,
&callback, &token));
#if defined(OS_WIN)
EXPECT_EQ(L"HTTP/alias:500", auth_handler->spn());
@@ -280,8 +277,7 @@ TEST_F(HttpAuthHandlerNegotiateTest, CnameSync) {
TestOldCompletionCallback callback;
HttpRequestInfo request_info;
std::string token;
- EXPECT_EQ(OK, auth_handler->GenerateAuthToken(NULL, NULL,
- &request_info,
+ EXPECT_EQ(OK, auth_handler->GenerateAuthToken(NULL, &request_info,
&callback, &token));
#if defined(OS_WIN)
EXPECT_EQ(L"HTTP/canonical.example.com", auth_handler->spn());
@@ -300,7 +296,7 @@ TEST_F(HttpAuthHandlerNegotiateTest, CnameAsync) {
HttpRequestInfo request_info;
std::string token;
EXPECT_EQ(ERR_IO_PENDING, auth_handler->GenerateAuthToken(
- NULL, NULL, &request_info, &callback, &token));
+ NULL, &request_info, &callback, &token));
EXPECT_EQ(OK, callback.WaitForResult());
#if defined(OS_WIN)
EXPECT_EQ(L"HTTP/canonical.example.com", auth_handler->spn());
@@ -323,7 +319,7 @@ TEST_F(HttpAuthHandlerNegotiateTest, ServerNotInKerberosDatabase) {
HttpRequestInfo request_info;
std::string token;
EXPECT_EQ(ERR_IO_PENDING, auth_handler->GenerateAuthToken(
- NULL, NULL, &request_info, &callback, &token));
+ NULL, &request_info, &callback, &token));
EXPECT_EQ(ERR_MISSING_AUTH_CREDENTIALS, callback.WaitForResult());
}
@@ -339,7 +335,7 @@ TEST_F(HttpAuthHandlerNegotiateTest, NoKerberosCredentials) {
HttpRequestInfo request_info;
std::string token;
EXPECT_EQ(ERR_IO_PENDING, auth_handler->GenerateAuthToken(
- NULL, NULL, &request_info, &callback, &token));
+ NULL, &request_info, &callback, &token));
EXPECT_EQ(ERR_MISSING_AUTH_CREDENTIALS, callback.WaitForResult());
}
« no previous file with comments | « net/http/http_auth_handler_negotiate.cc ('k') | net/http/http_auth_handler_ntlm.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698