net/http/http_auth_handler_basic.h - Issue 8340026: Use AuthCredentials throughout the network stack instead of username/password.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_auth_handler_basic.h

Issue 8340026: Use AuthCredentials throughout the network stack instead of username/password. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fix comments Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_auth_handler_basic.h

diff --git a/net/http/http_auth_handler_basic.h b/net/http/http_auth_handler_basic.h

index ab1d397415d7bc8c68651a893bec0c1d7441e775..5952d73483d0611f891f28de8c9b880fecb3b909 100644

--- a/net/http/http_auth_handler_basic.h

+++ b/net/http/http_auth_handler_basic.h

@@ -8,7 +8,6 @@

#include <string>

-#include "base/string16.h"

#include "net/base/net_export.h"

#include "net/http/http_auth_handler.h"

#include "net/http/http_auth_handler_factory.h"

@@ -38,8 +37,7 @@ class NET_EXPORT_PRIVATE HttpAuthHandlerBasic : public HttpAuthHandler {

protected:

virtual bool Init(HttpAuth::ChallengeTokenizer* challenge);

- virtual int GenerateAuthTokenImpl(const string16* username,

- const string16* password,

+ virtual int GenerateAuthTokenImpl(const AuthCredentials* credentials,

const HttpRequestInfo* request,

OldCompletionCallback* callback,

std::string* auth_token);

« no previous file with comments | « net/http/http_auth_handler.cc ('k') | net/http/http_auth_handler_basic.cc » ('j') | no next file with comments »