net/ftp/ftp_transaction.h - Issue 8340026: Use AuthCredentials throughout the network stack instead of username/password.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/ftp/ftp_transaction.h

Issue 8340026: Use AuthCredentials throughout the network stack instead of username/password. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fix comments Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/ftp/ftp_transaction.h

diff --git a/net/ftp/ftp_transaction.h b/net/ftp/ftp_transaction.h

index 300468ba2fe8a43f3b673513cc8c5050b30a11ba..269c8bb7741116891c6dc02134f68a5c977e2d6f 100644

--- a/net/ftp/ftp_transaction.h

+++ b/net/ftp/ftp_transaction.h

@@ -6,7 +6,6 @@

#define NET_FTP_FTP_TRANSACTION_H_

#pragma once

-#include "base/string16.h"

#include "net/base/completion_callback.h"

#include "net/base/io_buffer.h"

#include "net/base/load_states.h"

@@ -14,6 +13,7 @@

namespace net {

+class AuthCredentials;

class FtpResponseInfo;

class FtpRequestInfo;

class BoundNetLog;

@@ -44,8 +44,7 @@ class NET_EXPORT_PRIVATE FtpTransaction {

const BoundNetLog& net_log) = 0;

// Restarts the FTP transaction with authentication credentials.

- virtual int RestartWithAuth(const string16& username,

- const string16& password,

+ virtual int RestartWithAuth(const AuthCredentials& credentials,

OldCompletionCallback* callback) = 0;

// Once response info is available for the transaction, response data may be

« no previous file with comments | « net/ftp/ftp_network_transaction_unittest.cc ('k') | net/http/http_auth.h » ('j') | no next file with comments »