chrome/browser/ui/login/login_prompt.cc - Issue 8340026: Use AuthCredentials throughout the network stack instead of username/password.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/login/login_prompt.cc

Issue 8340026: Use AuthCredentials throughout the network stack instead of username/password. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: mac compile fix Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/login/login_prompt.cc

diff --git a/chrome/browser/ui/login/login_prompt.cc b/chrome/browser/ui/login/login_prompt.cc

index 0e5135ee140442861769a34ef5f9aee1f986a56b..951af785988dd042d60c378e74dc3f309654cd1b 100644

--- a/chrome/browser/ui/login/login_prompt.cc

+++ b/chrome/browser/ui/login/login_prompt.cc

@@ -360,7 +360,7 @@ void LoginHandler::SetAuthDeferred(const string16& username,

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

if (request_) {

- request_->SetAuth(username, password);

+ request_->SetAuth(net::AuthCredentials(username, password));

asanka 2011/10/27 20:01:20 Perhaps create a net::AuthCredentials object befor

cbentzel 2011/10/28 02:18:40 I did that initially, but then it ended up propaga

ResetLoginHandlerForRequest(request_);

}

« no previous file with comments | « chrome/browser/extensions/extension_webrequest_api.cc ('k') | net/base/auth.h » ('j') | net/base/auth.cc » ('J')