Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Side by Side Diff: net/url_request/url_request_ftp_job.h

Issue 8340026: Use AuthCredentials throughout the network stack instead of username/password. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Reduce password zapping Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_URL_REQUEST_URL_REQUEST_FTP_JOB_H_ 5 #ifndef NET_URL_REQUEST_URL_REQUEST_FTP_JOB_H_
6 #define NET_URL_REQUEST_URL_REQUEST_FTP_JOB_H_ 6 #define NET_URL_REQUEST_URL_REQUEST_FTP_JOB_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 10
11 #include "base/string16.h" 11 #include "base/string16.h"
asanka 2011/10/28 14:39:40 Not needed?
12 #include "base/task.h" 12 #include "base/task.h"
13 #include "net/base/auth.h" 13 #include "net/base/auth.h"
14 #include "net/base/completion_callback.h" 14 #include "net/base/completion_callback.h"
15 #include "net/ftp/ftp_request_info.h" 15 #include "net/ftp/ftp_request_info.h"
16 #include "net/ftp/ftp_transaction.h" 16 #include "net/ftp/ftp_transaction.h"
17 #include "net/url_request/url_request_job.h" 17 #include "net/url_request/url_request_job.h"
18 18
19 namespace net { 19 namespace net {
20 20
21 class URLRequestContext; 21 class URLRequestContext;
(...skipping 17 matching lines...) Expand all
39 void StartTransaction(); 39 void StartTransaction();
40 40
41 void OnStartCompleted(int result); 41 void OnStartCompleted(int result);
42 void OnReadCompleted(int result); 42 void OnReadCompleted(int result);
43 43
44 void RestartTransactionWithAuth(); 44 void RestartTransactionWithAuth();
45 45
46 void LogFtpServerType(char server_type); 46 void LogFtpServerType(char server_type);
47 47
48 // Overridden from URLRequestJob: 48 // Overridden from URLRequestJob:
49 virtual void Start(); 49 virtual void Start() OVERRIDE;
50 virtual void Kill(); 50 virtual void Kill() OVERRIDE;
51 virtual LoadState GetLoadState() const; 51 virtual LoadState GetLoadState() const OVERRIDE;
52 virtual bool NeedsAuth(); 52 virtual bool NeedsAuth() OVERRIDE;
53 virtual void GetAuthChallengeInfo( 53 virtual void GetAuthChallengeInfo(
54 scoped_refptr<AuthChallengeInfo>* auth_info); 54 scoped_refptr<AuthChallengeInfo>* auth_info) OVERRIDE;
55 virtual void SetAuth(const string16& username, 55 virtual void SetAuth(const AuthCredentials& credentials) OVERRIDE;
56 const string16& password); 56 virtual void CancelAuth() OVERRIDE;
57 virtual void CancelAuth();
58 57
59 // TODO(ibrar): Yet to give another look at this function. 58 // TODO(ibrar): Yet to give another look at this function.
60 virtual uint64 GetUploadProgress() const; 59 virtual uint64 GetUploadProgress() const;
61 virtual bool ReadRawData(IOBuffer* buf, int buf_size, int *bytes_read); 60 virtual bool ReadRawData(IOBuffer* buf, int buf_size, int *bytes_read);
62 61
63 FtpRequestInfo request_info_; 62 FtpRequestInfo request_info_;
64 scoped_ptr<FtpTransaction> transaction_; 63 scoped_ptr<FtpTransaction> transaction_;
65 64
66 OldCompletionCallbackImpl<URLRequestFtpJob> start_callback_; 65 OldCompletionCallbackImpl<URLRequestFtpJob> start_callback_;
67 OldCompletionCallbackImpl<URLRequestFtpJob> read_callback_; 66 OldCompletionCallbackImpl<URLRequestFtpJob> read_callback_;
68 67
69 bool read_in_progress_; 68 bool read_in_progress_;
70 69
71 scoped_refptr<AuthData> server_auth_; 70 scoped_refptr<AuthData> server_auth_;
72 71
73 // Keep a reference to the url request context to be sure it's not deleted 72 // Keep a reference to the url request context to be sure it's not deleted
74 // before us. 73 // before us.
75 scoped_refptr<const URLRequestContext> context_; 74 scoped_refptr<const URLRequestContext> context_;
76 75
77 ScopedRunnableMethodFactory<URLRequestFtpJob> method_factory_; 76 ScopedRunnableMethodFactory<URLRequestFtpJob> method_factory_;
78 77
79 DISALLOW_COPY_AND_ASSIGN(URLRequestFtpJob); 78 DISALLOW_COPY_AND_ASSIGN(URLRequestFtpJob);
80 }; 79 };
81 80
82 } // namespace net 81 } // namespace net
83 82
84 #endif // NET_URL_REQUEST_URL_REQUEST_FTP_JOB_H_ 83 #endif // NET_URL_REQUEST_URL_REQUEST_FTP_JOB_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698