Use AuthCredentials throughout the network stack instead of username/password.

net/http/http_cache_transaction.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file declares HttpCache::Transaction, a private class of HttpCache so
 // it should only be included by http_cache.cc
 
 #ifndef NET_HTTP_HTTP_CACHE_TRANSACTION_H_
 #define NET_HTTP_HTTP_CACHE_TRANSACTION_H_
 #pragma once
 
 #include <string>
 
 #include "base/string16.h"

[asanka, 2011/10/28 14:39:40]

base/string16.h not needed?

 #include "base/time.h"
 #include "net/base/net_log.h"
 #include "net/http/http_cache.h"
 #include "net/http/http_response_info.h"
 #include "net/http/http_request_headers.h"
 #include "net/http/http_transaction.h"
 
 namespace net {
 
 class HttpResponseHeaders;
@@ skipping 71 matching lines @@
   OldCompletionCallback* io_callback() { return &io_callback_; }
 
   const BoundNetLog& net_log() const;
 
   // HttpTransaction methods:
   virtual int Start(const HttpRequestInfo*, OldCompletionCallback*,
                     const BoundNetLog&);
   virtual int RestartIgnoringLastError(OldCompletionCallback* callback);
   virtual int RestartWithCertificate(X509Certificate* client_cert,
                                      OldCompletionCallback* callback);
-  virtual int RestartWithAuth(const string16& username,
-                              const string16& password,
+  virtual int RestartWithAuth(const AuthCredentials& credentials,
                               OldCompletionCallback* callback);
   virtual bool IsReadyToRestartForAuth();
   virtual int Read(IOBuffer* buf, int buf_len, OldCompletionCallback* callback);
   virtual void StopCaching();
   virtual void DoneReading();
   virtual const HttpResponseInfo* GetResponseInfo() const;
   virtual LoadState GetLoadState() const;
   virtual uint64 GetUploadProgress(void) const;
 
  private:
@@ skipping 133 matching lines @@
   // Called to restart a network transaction after an error.  Returns network
   // error code.
   int RestartNetworkRequest();
 
   // Called to restart a network transaction with a client certificate.
   // Returns network error code.
   int RestartNetworkRequestWithCertificate(X509Certificate* client_cert);
 
   // Called to restart a network transaction with authentication credentials.
   // Returns network error code.
-  int RestartNetworkRequestWithAuth(const string16& username,
-                                    const string16& password);
+  int RestartNetworkRequestWithAuth(const AuthCredentials& credentials);
 
   // Called to determine if we need to validate the cache entry before using it.
   bool RequiresValidation();
 
   // Called to make the request conditional (to ask the server if the cached
   // copy is valid).  Returns true if able to make the request conditional.
   bool ConditionalizeRequest();
 
   // Makes sure that a 206 response is expected.  Returns true on success.
   // On success, handling_206_ will be set to true if we are processing a
@@ skipping 88 matching lines @@
   uint64 final_upload_progress_;
   OldCompletionCallbackImpl<Transaction> io_callback_;
   scoped_refptr<CancelableOldCompletionCallback<Transaction> > cache_callback_;
   scoped_refptr<CancelableOldCompletionCallback<Transaction> >
       write_headers_callback_;
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_HTTP_CACHE_TRANSACTION_H_