Issue 8340023: Remove stack height tracking from ia32 non-optimizing code generator. Reverts change 8755.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8340023: Remove stack height tracking from ia32 non-optimizing code generator. Reverts change 8755. (Closed)

Created:
9 years, 1 month ago by William Hesse

Modified:
9 years, 1 month ago

Reviewers:
fschneider

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Remove stack height tracking from ia32 non-optimizing code generator. Committed: http://code.google.com/p/v8/source/detail?r=9857

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -185 lines)			Patch
M	src/flag-definitions.h	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/full-codegen.h	View	1 2	9 chunks	+4 lines, -49 lines	0 comments	Download
M	src/full-codegen.cc	View	1 2	11 chunks	+0 lines, -18 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	1 2	76 chunks	+5 lines, -117 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

William Hesse

Change to code throwing error for invalid LHS of assignment was changed to more complex ...

9 years, 1 month ago (2011-10-27 11:45:47 UTC) #1

fschneider

9 years, 1 month ago (2011-11-01 12:12:07 UTC) #2

LGTM.

http://codereview.chromium.org/8340023/diff/2002/src/ia32/full-codegen-ia32.cc
File src/ia32/full-codegen-ia32.cc (right):

http://codereview.chromium.org/8340023/diff/2002/src/ia32/full-codegen-ia32.c...
src/ia32/full-codegen-ia32.cc:2200: 
Empty line.

Expand Messages | Collapse Messages