Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Issue 8340019: Try a workaround for initMessageEvent bug. (Closed)

Created:
9 years, 1 month ago by dmichael (off chromium)
Modified:
9 years, 1 month ago
Reviewers:
brettw, viettrungluu
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Try a workaround for initMessageEvent bug. BUG= http://code.google.com/p/nativeclient/issues/detail?id=2394 TEST=cd native_client; ./scons --mode=opt-host,nacl chrome_browser_tests Note: For some reason, trybot runs aren't appearing here. You can see them at: http://build.chromium.org/p/tryserver.chromium/waterfall?committer=dmichael@chromium.org The constructor is the 'new right way' to do it anyway: http://www.whatwg.org/specs/web-apps/current-work/multipage/comms.html Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107591

Patch Set 1 #

Patch Set 2 : Update the Note. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -17 lines) Patch
M webkit/plugins/ppapi/message_channel.cc View 1 1 chunk +10 lines, -17 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dmichael (off chromium)
I can find another reviewer if you're busy, but not too many people are in ...
9 years, 1 month ago (2011-10-27 15:30:23 UTC) #1
viettrungluu
I'm told that the constructor is the new way to do things and should be ...
9 years, 1 month ago (2011-10-27 17:11:00 UTC) #2
commit-bot: I haz the power
9 years, 1 month ago (2011-10-27 17:13:07 UTC) #3

Powered by Google App Engine
This is Rietveld 408576698