Minimize resize calls

views/controls/native/native_view_host.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "views/controls/native/native_view_host.h"
 
 #include "base/logging.h"
 #include "ui/gfx/canvas.h"
 #include "views/controls/native/native_view_host_views.h"
 #include "views/controls/native/native_view_host_wrapper.h"
@@ skipping 134 matching lines @@
 }
 
 void NativeViewHost::VisibilityChanged(View* starting_from, bool is_visible) {
   Layout();
 }
 
 bool NativeViewHost::NeedsNotificationWhenVisibleBoundsChange() const {
   // The native widget is placed relative to the root. As such, we need to
   // know when the position of any ancestor changes, or our visibility relative
   // to other views changed as it'll effect our position relative to the root.
+#if !defined(USE_AURA)
   return true;
+#else
+  return false;

[sky, 2011/10/27 14:40:47]

This comment seems to apply to aura. Why do we want to return false here?

[DaveMoore, 2011/10/27 21:25:13]

Do we need this when there's only one native window to host everything? What I
saw was that this gets triggered by the bounds change and then it causes us to
do another layout. I saw no downside on the device when I changed this.

On 2011/10/27 14:40:47, sky wrote:

[sky, 2011/10/27 22:12:20]

We still have child windows for the TabContents and RWHV. If we had a situation
where the position in the parent changed but the bounds didn't, then we would
want this code.
Shouldn't it result in a no-op because we invoke SetBounds with the same bounds,
which because of your change to Window does nothing?

[DaveMoore, 2011/10/28 16:46:48]

Done.

+#endif
 }
 
 void NativeViewHost::OnVisibleBoundsChanged() {
   Layout();
 }
 
 void NativeViewHost::ViewHierarchyChanged(bool is_add, View* parent,
                                           View* child) {
   if (is_add && GetWidget()) {
     if (!native_wrapper_.get())
@@ skipping 29 matching lines @@
 // NativeViewHost, private:
 
 void NativeViewHost::Detach(bool destroyed) {
   DCHECK(native_view_ || views_view_);
   native_wrapper_->NativeViewDetaching(destroyed);
   native_view_ = NULL;
   views_view_ = NULL;
 }
 
 }  // namespace views