Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Unified Diff: net/socket/socks_client_socket_pool.h

Issue 8340012: Close idle connections / SPDY sessions when needed. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: OVERRIDE Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/socks_client_socket_pool.h
diff --git a/net/socket/socks_client_socket_pool.h b/net/socket/socks_client_socket_pool.h
index 11dbd3395bd1e97cb43ec3b7b0102d83f224b3cd..04bcfbe2bc74c45f3dd2e6643f3a1c4ce61047d0 100644
--- a/net/socket/socks_client_socket_pool.h
+++ b/net/socket/socks_client_socket_pool.h
@@ -105,7 +105,8 @@ class SOCKSConnectJob : public ConnectJob {
DISALLOW_COPY_AND_ASSIGN(SOCKSConnectJob);
};
-class NET_EXPORT_PRIVATE SOCKSClientSocketPool : public ClientSocketPool {
+class NET_EXPORT_PRIVATE SOCKSClientSocketPool
+ : public ClientSocketPool, public LayeredPool {
public:
SOCKSClientSocketPool(
int max_sockets,
@@ -123,39 +124,50 @@ class NET_EXPORT_PRIVATE SOCKSClientSocketPool : public ClientSocketPool {
RequestPriority priority,
ClientSocketHandle* handle,
OldCompletionCallback* callback,
- const BoundNetLog& net_log);
+ const BoundNetLog& net_log) OVERRIDE;
virtual void RequestSockets(const std::string& group_name,
const void* params,
int num_sockets,
- const BoundNetLog& net_log);
+ const BoundNetLog& net_log) OVERRIDE;
virtual void CancelRequest(const std::string& group_name,
- ClientSocketHandle* handle);
+ ClientSocketHandle* handle) OVERRIDE;
virtual void ReleaseSocket(const std::string& group_name,
StreamSocket* socket,
- int id);
+ int id) OVERRIDE;
- virtual void Flush();
+ virtual void Flush() OVERRIDE;
- virtual void CloseIdleSockets();
+ virtual bool IsStalled() const OVERRIDE;
- virtual int IdleSocketCount() const;
+ virtual void CloseIdleSockets() OVERRIDE;
- virtual int IdleSocketCountInGroup(const std::string& group_name) const;
+ virtual int IdleSocketCount() const OVERRIDE;
- virtual LoadState GetLoadState(const std::string& group_name,
- const ClientSocketHandle* handle) const;
+ virtual int IdleSocketCountInGroup(
+ const std::string& group_name) const OVERRIDE;
+
+ virtual LoadState GetLoadState(
+ const std::string& group_name,
+ const ClientSocketHandle* handle) const OVERRIDE;
+
+ virtual void AddLayeredPool(LayeredPool* layered_pool) OVERRIDE;
+
+ virtual void RemoveLayeredPool(LayeredPool* layered_pool) OVERRIDE;
virtual base::DictionaryValue* GetInfoAsValue(
const std::string& name,
const std::string& type,
- bool include_nested_pools) const;
+ bool include_nested_pools) const OVERRIDE;
+
+ virtual base::TimeDelta ConnectionTimeout() const OVERRIDE;
- virtual base::TimeDelta ConnectionTimeout() const;
+ virtual ClientSocketPoolHistograms* histograms() const OVERRIDE;
- virtual ClientSocketPoolHistograms* histograms() const;
+ // LayeredPool methods:
+ virtual bool CloseOneIdleConnection() OVERRIDE;
private:
typedef ClientSocketPoolBase<SOCKSSocketParams> PoolBase;

Powered by Google App Engine
This is Rietveld 408576698