Issue 8340008: Rewrite FFmpegVideoDecoder tests based on existing FFmpegVideoDecodeEngine tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8340008: Rewrite FFmpegVideoDecoder tests based on existing FFmpegVideoDecodeEngine tests. (Closed)

Created:
9 years, 1 month ago by scherkus (not reviewing)

Modified:
9 years, 1 month ago

Reviewers:
acolwell GONE FROM CHROMIUM

CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, Paweł Hajdan Jr., acolwell+watch_chromium.org, annacc+watch_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Rewrite FFmpegVideoDecoder tests based on existing FFmpegVideoDecodeEngine tests. The old tests were mostly useless as they tested using a mocked VideoDecodeEngine. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107681

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : moar tests #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+434 lines, -299 lines)			Patch
	M	media/filters/ffmpeg_video_decoder_unittest.cc	View	1 2	1 chunk	+434 lines, -299 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/8340008/4001

9 years, 1 month ago (2011-10-28 02:35:58 UTC) #3

commit-bot: I haz the power

9 years, 1 month ago (2011-10-28 03:20:35 UTC) #4

Try job failure for 8340008-4001 (retry) on linux_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Expand Messages | Collapse Messages