Rename GrowableObjectArray to ListImplementation.

Rename GrowableObjectArray to ListImplementation.

[srdjan, 2011-10-18 11:48:24]

On 2011/10/18 11:24:41, ngeoffray wrote:

I need to think more about the rename of GrowableObjectArray to
ListImplementation. Can you provide arguments for it?

In my view there are two List implementations: ObjectArray and
GrowableObjectArray. Both are hidden, VM specific core classes. With this CL
calling new List(x) returns either an instance of ListImplementation or an
ObjectArray (depending if 'x' is null or not). I'd rather have class names as
GrowableObjectList and ObjectList (or similar).

Note that this change will degrade the performance as intrinsifier
(intrinsifier_ia32.cc) will not be able to recognize the library methods any
longer (easy fixable).

[Ivan Posva, 2011-10-19 00:16:15]

Please refrain from changing the internal implementation of VM core libraries,
even if only renaming some classes. This can break other unrelated assumptions
in the VM that you are not tracking as Srdjan already pointed out.

We plan to redo the VM's List implementation in many interesting ways which will
invalidate this change soon. The benefit of renaming one of the classes in the
short term is not obvious especially under this circumstance.

Also this change does not address the one real unresolved issue which is that we
still have a legacy Array interface lingering in the sources.

Thanks,
-Ivan

[Ivan Posva, 2011-10-19 00:54:32]

On 2011/10/19 00:16:15, Ivan Posva wrote:
> Please refrain from changing the internal implementation of VM core libraries,
> even if only renaming some classes. This can break other unrelated assumptions
> in the VM that you are not tracking as Srdjan already pointed out.
> 
> We plan to redo the VM's List implementation in many interesting ways which
will
> invalidate this change soon. The benefit of renaming one of the classes in the
> short term is not obvious especially under this circumstance.
> 
> Also this change does not address the one real unresolved issue which is that
we
> still have a legacy Array interface lingering in the sources.

Fixed in http://codereview.chromium.org/8348025/

-Ivan


> 
> Thanks,
> -Ivan

[ngeoffray, 2011-10-19 07:50:25]

Closing it then, I'll let you guys handle the mess :-)