Options: Disable the delete button when no profile is selected in personal settings.

chrome/browser/resources/options/personal_options.js

Index: chrome/browser/resources/options/personal_options.js
diff --git a/chrome/browser/resources/options/personal_options.js b/chrome/browser/resources/options/personal_options.js
index 23483d01a22fd0f27e2d2e8adac4a2c5a06e742a..9375685e96ba2fe5bbc1dd3bde831b321a739400 100644
--- a/chrome/browser/resources/options/personal_options.js
+++ b/chrome/browser/resources/options/personal_options.js
@@ -62,7 +62,8 @@ cr.define('options', function() {
         var hasSelection = selectedProfile != null;
         var hasSingleProfile = profilesList.dataModel.length == 1;
         $('profiles-manage').disabled = !hasSelection;
-        $('profiles-delete').disabled = !hasSingleProfile && !hasSelection;
+        $('profiles-delete').disabled = hasSingleProfile ?
+            !hasSingleProfile : !hasSelection;

[Evan Stade, 2011/10/18 16:18:57]

hasSingleProfile ? false : !hasSelection;

[Miranda Callahan, 2011/10/18 16:40:34]

This looks to me like it doesn't change the logic -- perhaps I'm missing
something obvious?

If hasSingleProfile is true, disabled will always be false in both cases.
If hasSingleProfile is false, disabled will be the opposite of hasSelection in
both cases.

Shouldn't the change be 

...disabled = !hasSelection || hasSingleProfile;

That is -- always disable the button if there's no selection, and additionally
always disable it if there's only a single profile (until
http://code.google.com/p/chromium/issues/detail?id=94586 is solved)?

[binji, 2011/10/18 17:57:07]

I agree w/ Miranda:

!hasSelection || hasSingleProfile

I'll switch it after the fix to crbug.com/94586 lands.

[NaveenBobbili (Motorola), 2011/10/19 06:51:17]

Done.

       };
       $('profiles-create').onclick = function(event) {
         chrome.send('createProfile');
@@ -225,6 +226,7 @@ cr.define('options', function() {
       $('profiles-list').hidden = hasSingleProfile;
       $('profiles-single-message').hidden = !hasSingleProfile;
       $('profiles-manage').hidden = hasSingleProfile;
+      $('profiles-delete').disabled = !hasSingleProfile;

[Miranda Callahan, 2011/10/18 16:40:34]

This seems like the opposite of what we should do. If there are multiple
profiles, we should not disable the delete button -- only if there is one
profile.

       $('profiles-delete').textContent = hasSingleProfile ?
           templateData.profilesDeleteSingle :
           templateData.profilesDelete;