Options: Disable the delete button when no profile is selected in personal settings.

chrome/browser/resources/options/personal_options.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
 
   var OptionsPage = options.OptionsPage;
   var ArrayDataModel = cr.ui.ArrayDataModel;
 
   // State variables.
@@ skipping 44 matching lines @@
       // Profiles.
       var profilesList = $('profiles-list');
       options.personal_options.ProfileList.decorate(profilesList);
       profilesList.autoExpands = true;
 
       profilesList.onchange = function(event) {
         var selectedProfile = profilesList.selectedItem;
         var hasSelection = selectedProfile != null;
         var hasSingleProfile = profilesList.dataModel.length == 1;
         $('profiles-manage').disabled = !hasSelection;
-        $('profiles-delete').disabled = !hasSingleProfile && !hasSelection;
+        $('profiles-delete').disabled = hasSingleProfile ?
+            false : !hasSelection;

[Miranda Callahan, 2011/10/19 12:42:23]

This logic is incorrect. Please reread my comments carefully.

[NaveenBobbili (Motorola), 2011/10/19 13:01:09]

Done.

       };
       $('profiles-create').onclick = function(event) {
         chrome.send('createProfile');
       };
       $('profiles-manage').onclick = function(event) {
         var selectedProfile = self.getSelectedProfileItem_();
         if (selectedProfile)
           ManageProfileOverlay.showManageDialog(selectedProfile);
       };
       $('profiles-delete').onclick = function(event) {
@@ skipping 159 matching lines @@
      * @param {Array.<Object>} An array of profile info objects.
      *     each object is of the form:
      *       profileInfo = {
      *         name: "Profile Name",
      *         iconURL: "chrome://path/to/icon/image",
      *         filePath: "/path/to/profile/data/on/disk",
      *         isCurrentProfile: false
      *       };
      */
     setProfilesInfo_: function(profiles) {
+      var profilesList = $('profiles-list');
       this.setProfileViewSingle_(profiles.length);
       // add it to the list, even if the list is hidden so we can access it
       // later.
-      $('profiles-list').dataModel = new ArrayDataModel(profiles);
+      profilesList.dataModel = new ArrayDataModel(profiles);
+      // Enable/Disable delete and edit buttons based on the number of profiles
+      // and the selection status.
+      var hasSelection = profilesList.selectedItem != null;
+      var hasSingleProfile = profilesList.dataModel.length == 1;
+      this.setDeleteButtonEnabled_(hasSingleProfile || hasSelection);

[Miranda Callahan, 2011/10/19 12:42:23]

This logic is also wrong; for now, the delete button should *not* be enabled if
there is only one profile.

[NaveenBobbili (Motorola), 2011/10/19 13:01:09]

Done.

+      this.setEditButtonEnabled_(hasSelection);
+    },
+
+    setDeleteButtonEnabled_: function(enabled) {
+      $('profiles-delete').disabled = !enabled;
+    },
+
+    setEditButtonEnabled_: function(enabled) {
+      $('profiles-manage').disabled = !enabled;
     },
 
     setStartStopButtonVisible_: function(visible) {
       $('start-stop-sync').hidden = !visible;
     },
 
     setStartStopButtonEnabled_: function(enabled) {
       $('start-stop-sync').disabled = !enabled;
     },
 
@@ skipping 75 matching lines @@
       PersonalOptions.getInstance()[name + '_'](value);
     };
   });
 
   // Export
   return {
     PersonalOptions: PersonalOptions
   };
 
 });