Options: Disable the delete button when no profile is selected in personal settings.

chrome/browser/resources/options/personal_options.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
 
   var OptionsPage = options.OptionsPage;
   var ArrayDataModel = cr.ui.ArrayDataModel;
 
   // State variables.
@@ skipping 44 matching lines @@
       // Profiles.
       var profilesList = $('profiles-list');
       options.personal_options.ProfileList.decorate(profilesList);
       profilesList.autoExpands = true;
 
       profilesList.onchange = function(event) {
         var selectedProfile = profilesList.selectedItem;
         var hasSelection = selectedProfile != null;
         var hasSingleProfile = profilesList.dataModel.length == 1;
         $('profiles-manage').disabled = !hasSelection;
-        $('profiles-delete').disabled = !hasSingleProfile && !hasSelection;
+        $('profiles-delete').disabled = hasSingleProfile ?
+            !hasSingleProfile : !hasSelection;

[Evan Stade, 2011/10/18 16:18:57]

hasSingleProfile ? false : !hasSelection;

[Miranda Callahan, 2011/10/18 16:40:34]

This looks to me like it doesn't change the logic -- perhaps I'm missing
something obvious?

If hasSingleProfile is true, disabled will always be false in both cases.
If hasSingleProfile is false, disabled will be the opposite of hasSelection in
both cases.

Shouldn't the change be 

...disabled = !hasSelection || hasSingleProfile;

That is -- always disable the button if there's no selection, and additionally
always disable it if there's only a single profile (until
http://code.google.com/p/chromium/issues/detail?id=94586 is solved)?

[binji, 2011/10/18 17:57:07]

I agree w/ Miranda:

!hasSelection || hasSingleProfile

I'll switch it after the fix to crbug.com/94586 lands.

[NaveenBobbili (Motorola), 2011/10/19 06:51:17]

Done.

       };
       $('profiles-create').onclick = function(event) {
         chrome.send('createProfile');
       };
       $('profiles-manage').onclick = function(event) {
         var selectedProfile = self.getSelectedProfileItem_();
         if (selectedProfile)
           ManageProfileOverlay.showManageDialog(selectedProfile);
       };
       $('profiles-delete').onclick = function(event) {
@@ skipping 142 matching lines @@
     /**
      * Display the correct dialog layout, depending on how many profiles are
      * available.
      * @param {number} numProfiles The number of profiles to display.
      */
     setProfileViewSingle_: function(numProfiles) {
       var hasSingleProfile = numProfiles == 1;
       $('profiles-list').hidden = hasSingleProfile;
       $('profiles-single-message').hidden = !hasSingleProfile;
       $('profiles-manage').hidden = hasSingleProfile;
+      $('profiles-delete').disabled = !hasSingleProfile;

[Miranda Callahan, 2011/10/18 16:40:34]

This seems like the opposite of what we should do. If there are multiple
profiles, we should not disable the delete button -- only if there is one
profile.

       $('profiles-delete').textContent = hasSingleProfile ?
           templateData.profilesDeleteSingle :
           templateData.profilesDelete;
     },
 
     /**
      * Adds all |profiles| to the list.
      * @param {Array.<Object>} An array of profile info objects.
      *     each object is of the form:
      *       profileInfo = {
@@ skipping 96 matching lines @@
       PersonalOptions.getInstance()[name + '_'](value);
     };
   });
 
   // Export
   return {
     PersonalOptions: PersonalOptions
   };
 
 });