Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: runtime/vm/class_finalizer.cc

Issue 8339003: Fix build breakage (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/class_finalizer.cc
===================================================================
--- runtime/vm/class_finalizer.cc (revision 491)
+++ runtime/vm/class_finalizer.cc (working copy)
@@ -125,6 +125,7 @@
ASSERT(!cls.is_interface());
GrowableArray<const Class*> interfaces;
CollectInterfaces(cls, &interfaces);
+ const String& class_name = String::Handle(cls.Name());
for (int i = 0; i < interfaces.length(); i++) {
const String& interface_name = String::Handle(interfaces[i]->Name());
const Array& interface_functions =
@@ -152,13 +153,11 @@
class_function = test_class.LookupDynamicFunction(function_name);
}
if (class_function.IsNull()) {
- const String& class_name = String::Handle(cls.Name());
OS::Print("%s implements '%s' missing: '%s'\n",
class_name.ToCString(),
interface_name.ToCString(),
function_name.ToCString());
- } else if (!class_function.IsSubtypeOf(interface_function)) {
- const String& class_name = String::Handle(cls.Name());
+ } else if (class_function.IsSubtypeOf(interface_function)) {
OS::Print("The type of instance method '%s' in class '%s' is not a "
"subtype of the type of '%s' in interface '%s'\n",
function_name.ToCString(),
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698