Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1228)

Side by Side Diff: src/arm/simulator-arm.cc

Issue 8337014: Increase ARM/MIPS simulators stack safety margin to 512 bytes (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/mips/simulator-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1250 matching lines...) Expand 10 before | Expand all | Expand 10 after
1261 return; 1261 return;
1262 } 1262 }
1263 PrintF("Unaligned write at 0x%08x\n", addr); 1263 PrintF("Unaligned write at 0x%08x\n", addr);
1264 UNIMPLEMENTED(); 1264 UNIMPLEMENTED();
1265 #endif 1265 #endif
1266 } 1266 }
1267 1267
1268 1268
1269 // Returns the limit of the stack area to enable checking for stack overflows. 1269 // Returns the limit of the stack area to enable checking for stack overflows.
1270 uintptr_t Simulator::StackLimit() const { 1270 uintptr_t Simulator::StackLimit() const {
1271 // Leave a safety margin of 256 bytes to prevent overrunning the stack when 1271 // Leave a safety margin of 512 bytes to prevent overrunning the stack when
1272 // pushing values. 1272 // pushing values.
1273 return reinterpret_cast<uintptr_t>(stack_) + 256; 1273 return reinterpret_cast<uintptr_t>(stack_) + 512;
1274 } 1274 }
1275 1275
1276 1276
1277 // Unsupported instructions use Format to print an error and stop execution. 1277 // Unsupported instructions use Format to print an error and stop execution.
1278 void Simulator::Format(Instruction* instr, const char* format) { 1278 void Simulator::Format(Instruction* instr, const char* format) {
1279 PrintF("Simulator found unsupported instruction:\n 0x%08x: %s\n", 1279 PrintF("Simulator found unsupported instruction:\n 0x%08x: %s\n",
1280 reinterpret_cast<intptr_t>(instr), format); 1280 reinterpret_cast<intptr_t>(instr), format);
1281 UNIMPLEMENTED(); 1281 UNIMPLEMENTED();
1282 } 1282 }
1283 1283
(...skipping 2133 matching lines...) Expand 10 before | Expand all | Expand 10 after
3417 uintptr_t address = *stack_slot; 3417 uintptr_t address = *stack_slot;
3418 set_register(sp, current_sp + sizeof(uintptr_t)); 3418 set_register(sp, current_sp + sizeof(uintptr_t));
3419 return address; 3419 return address;
3420 } 3420 }
3421 3421
3422 } } // namespace v8::internal 3422 } } // namespace v8::internal
3423 3423
3424 #endif // USE_SIMULATOR 3424 #endif // USE_SIMULATOR
3425 3425
3426 #endif // V8_TARGET_ARCH_ARM 3426 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/mips/simulator-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698